Sidekiq: identify culprit + drop Sidekiq 2 #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
nateberkopec
force-pushed
the
better-transaction-names
branch
from
86d6315 to
ded4ee7
Compare
Contributor
Author
|
note to self, not sure if I should be clearing context/breadcrumb buffers |
nateberkopec
commented
Sep 27, 2016
| else | ||
| context | ||
| def culprit_from_context(context) | ||
| classname = (context["class"] || (context["job"] && context["job"]["class"])) |
Contributor
Author
There was a problem hiding this comment.
need to add a comment about this data structure is consistent in future versions of sidekiq, a la sidekiq/sidekiq#3161
| BreadcrumbBuffer.clear! | ||
| ACTIVEJOB_RESERVED_PREFIX = "_aj_".freeze | ||
|
|
||
| def call(ex, context) |
Contributor
Author
There was a problem hiding this comment.
this is a really simple middleware that can be tested in isolation from sidekiq, should add some tests
nateberkopec
force-pushed
the
better-transaction-names
branch
5 times, most recently
from
deb22cf to
c4fdc65
Compare
nateberkopec
force-pushed
the
better-transaction-names
branch
from
c4fdc65 to
1411ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is