Do not implicitly set up rack-timeout middleware #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By requiring `rack-timeout`, `Rack::Timeout` is automatically added to the middleware of a Rails application. See https://github.com/heroku/rack-timeout#rails-apps This leads to unexpected behavior. When a user adds a non-standard `Rack-Timeout` to the middleware stack herself, she ends up with `Rack-Timeout` added twice. Worse, the configuration added automatically is the standard configuration which might differ from the one added manually in user land. Worst case comes to show when a user configures a `service_timeout` greater than the standard one.
Contributor
|
Whoops, didn't know about 'rack/timeout/base'. Thanks for the catch. |
Contributor
|
Fixed in 2.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By requiring
rack-timeout,Rack::Timeoutis automatically added to the middleware of a Rails application.See https://github.com/heroku/rack-timeout#rails-apps
This leads to unexpected behavior. When a user adds a non-standard
Rack-Timeoutto the middleware stack herself, she ends up withRack-Timeoutadded twice. Worse, the configuration added automatically is the standard configuration which might differ from the one added manually in user land. Worst case comes to show when a user configures aservice_timeoutgreater than the standard one.The
"rack/timeout/base"entry point was added inv0.3.0ofrack-timeout, see zombocom/rack-timeout@39fdbae.I would advice to fix this rather sooner than later as all Rails apps using
sentry-ravenandrack-timeoutwith its manual configuration are affected by this.