Skip to content

Transport errors should raise Sentry errors, not Faraday #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Transport errors should raise Sentry errors, not Faraday #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/raven/transports/http.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def send_event(auth_header, data, options = {})
req.headers['X-Sentry-Auth'] = auth_header
req.body = data
end
rescue Faraday::ClientError => ex
raise Raven::Error, ex.message
end

private
Expand Down
Empty file removed spec/raven/transport_spec.rb
View file
Open in desktop
Empty file.
6 changes: 4 additions & 2 deletions spec/raven/transports/http_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
require 'spec_helper'

describe Raven::Transports::HTTP do
before do
Raven.configure do |config|
Expand All @@ -16,7 +18,7 @@
Raven.configure { |config| config.http_adapter = [:test, stubs] }

event = JSON.generate(Raven::Event.from_message("test").to_hash)
expect { Raven.client.send(:transport).send_event("test", event) }.to raise_error(Faraday::ResourceNotFound)
expect { Raven.client.send(:transport).send_event("test", event) }.to raise_error(Raven::Error)

stubs.verify_stubbed_calls
end
Expand All @@ -28,7 +30,7 @@
Raven.configure { |config| config.http_adapter = [:test, stubs] }

event = JSON.generate(Raven::Event.from_message("test").to_hash)
expect { Raven.client.send(:transport).send_event("test", event) }.to raise_error(Faraday::ClientError)
expect { Raven.client.send(:transport).send_event("test", event) }.to raise_error(Raven::Error)

stubs.verify_stubbed_calls
end
Expand Down