Fix infinite backoff under pressure #843
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling failed_send when should_try? returns false was resetting last_check, effectively disabling all logs until enough time passes between two call to send_event (36s here). Fixes getsentry#841
|
|
||
| unless @state.should_try? | ||
| failed_send(nil, event) | ||
| configuration.logger.error "Not sending event due to previous failure(s)." |
Contributor
There was a problem hiding this comment.
It would be cool if we could log here how long we have until the next attempt.
Contributor
There was a problem hiding this comment.
It's also important that the backtrace (essentially all the info on line 96) is still printed here.
For people that don't use i.e. Sidekiq to send their Sentry events (so, automated retry), they're going to lose this event forever.
Author
|
superseded by #886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling failed_send when should_try? returns false was resetting last_check, effectively disabling all logs until enough time passes between two call to send_event (36s here).
Fixes #841