Fix crash when Process.wait is used#895
Merged
HazAT merged 4 commits intogetsentry:masterfrom Nov 12, 2019
Merged
Conversation
Make `sys_command` compatible with `Process.wait` and `trap('CLD', 'IGNORE')`
|
Can this please be implemented. It's also fixing crashes for me. It was difficult to figure out what was the problem until I found this PR. Thank you. |
Contributor
Author
|
@HazAT can we see if this will work? |
HazAT
approved these changes
Nov 8, 2019
Member
HazAT
left a comment
HazAT
left a comment
There was a problem hiding this comment.
Thx! 🎉
Will do a release on monday!
Member
|
Oh, @asBrettisay Can you please fix the tests before merging? |
Contributor
Author
|
@HazAT Will do |
Contributor
Author
|
@HazAT Tests are passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
sys_commandtolerate a missing $CHILD_STATUS.Hi 👋 in my code I was using
Process.waitand found that it was causing this error in sentry-raven:undefined methodexitstatus' for nil:NilClass`My understanding is that calling
Process.waitclears out the ruby global for last child process, and this is causing the error. I think that sentry-raven should be able to work if I useProcess.waitor something similar like `trap('CLD', 'IGNORE') so I made a PR that I think will fix the issue. Hope that this helps 👍.