Ensure Processor::Cookie can run after Processor::RemoveCircularReferences #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
=======================================
Coverage 97.77% 97.78%
=======================================
Files 46 46
Lines 2159 2163 +4
=======================================
+ Hits 2111 2115 +4
Misses 48 48
Continue to review full report at Codecov.
|
|
@hongtron wow that's a great catch! I will give it a thorough look tomorrow. |
st0012
reviewed
Aug 21, 2020
hongtron
force-pushed
the
fix-cookie-processor
branch
from
0e1661d to
4af689b
Compare
|
@st0012 confirmed that I can run specs locally now - I made sure I saw a correct spec failure when the app code change was backed out. I also updated the PR description with an "Impact" section. Appreciate the fast response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This commit seems to have introduced a bug: getsentry/raven-ruby@ad440b9
Processor::RemoveCircularReferencesreplaces elements of the event with the string(...), butProcessor::Cookies#generate_masked_cookiesassumes that its param implements#merge(Stringdoes not). Previously,Processor::Cookieswas not run inRaven::Event#async_json_processors.Unfortunately I wasn't able to get the test suite running locally (getting an error about requiringFixed!rails), so apologies if I've accidentally added a failing specImpact
This exception (
undefined method 'merge' for "(...)":String) would be rescued, but could cause a large number of events to be sent synchronously instead of asynchronously.