Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/raven/processor/cookies.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def process_if_string_keys(data)
end

def generate_masked_cookies(cookies)
cookies.merge(cookies) { STRING_MASK }
cookies.merge(cookies) { STRING_MASK } if cookies.respond_to?(:merge)
end
end
end
3 changes: 2 additions & 1 deletion lib/raven/processor/removecircularreferences.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
module Raven
class Processor::RemoveCircularReferences < Processor
ELISION_STRING = "(...)".freeze
def process(value, visited = [])
return "(...)" if visited.include?(value.__id__)
return ELISION_STRING if visited.include?(value.__id__)

visited << value.__id__ if value.is_a?(Array) || value.is_a?(Hash)

Expand Down
15 changes: 15 additions & 0 deletions spec/raven/processors/cookies_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,19 @@
expect(result["request"]["some_other_data"]).to eq("still_here")
expect(result["request"]["headers"]["AnotherHeader"]).to eq("still_here")
end

it 'does not fail if it runs after Processor::RemoveCircularReferences' do
test_data = {
:request => {
:headers => {
"Cookie" => Raven::Processor::RemoveCircularReferences::ELISION_STRING,
"AnotherHeader" => "still_here"
},
:cookies => Raven::Processor::RemoveCircularReferences::ELISION_STRING,
:some_other_data => "still_here"
}
}

@processor.process(test_data)
end
end