feat: Switch to fragile library for non send handling #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This increases safety as before we did not have a sane way to handle thread reuse and also RwLock was just not the right way to protect this.
jan-auer
approved these changes
Jun 22, 2018
| #[cfg(feature = "with_client_implementation")] | ||
| unsafe impl Send for PendingProcessors {} | ||
| pub enum PendingProcessor { | ||
| Send(Box<FnOnce() -> Box<Fn(&mut Event) + Send + Sync> + Send + Sync>), |
Member
There was a problem hiding this comment.
Might be nice to have From for this.
Contributor
Author
There was a problem hiding this comment.
Ugh. I actually should remove the pub from here I think. This should be internal only now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to the fragile library to handle non send processors and solves potentially UB.