-
-
Notifications
You must be signed in to change notification settings - Fork 172
feat(backtrace): Stop truncating backtraces #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
=======================================
Coverage 73.81% 73.81%
=======================================
Files 64 64
Lines 7538 7504 -34
=======================================
- Hits 5564 5539 -25
+ Misses 1974 1965 -9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dead configuration option remains in public API
The extra_border_frames field in ClientOptions is no longer used anywhere after removing the backtrace trimming functionality, but it remains in the public API with documentation suggesting it has an effect. Users configuring this option will have their settings silently ignored, creating a confusing developer experience where the configuration appears valid but does nothing.
sentry-core/src/clientoptions.rs#L191-L194
sentry-rust/sentry-core/src/clientoptions.rs
Lines 191 to 194 in e05ce91
| pub session_mode: SessionMode, | |
| /// Border frames which indicate a border from a backtrace to | |
| /// useless internals. Some are automatically included. | |
| pub extra_border_frames: Vec<&'static str>, |
| "sentry_core::", | ||
| "sentry_types::", | ||
| "sentry_backtrace::", | ||
| "sentry_tracing::", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not having this would make a frame (that was previously trimmed away) belonging to sentry_tracing be marked as in-app when reporting errors through tracing::error, hence breaking grouping when done by the "in-app stack trace" algorithm.
This has been detected by my test matrix.
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I think we can make the changelog a bit more human-readable though :)
Description
Removes backtrace truncation entirely, by removing the
ClientOptionsfield and the whole logic to implement this behavior.This branch has been tested for grouping changes for all relevant integrations with code that can be found here: https://github.com/lcian/sentry-samples-rust/tree/main/stacktrace-truncation.
Issues
Close #885
Close RUST-100
Next steps