Skip to content

Conversation

@lcian
Copy link
Member

@lcian lcian commented Oct 30, 2025

Description

Removes backtrace truncation entirely, by removing the ClientOptions field and the whole logic to implement this behavior.
This branch has been tested for grouping changes for all relevant integrations with code that can be found here: https://github.com/lcian/sentry-samples-rust/tree/main/stacktrace-truncation.

Issues

Close #885
Close RUST-100

Next steps

  • Remove options from docs if they're there -- ✅ the options were not there in the first place
  • Release in a minor

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ffb2fda

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.81%. Comparing base (a57b91c) to head (ffb2fda).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #925   +/-   ##
=======================================
  Coverage   73.81%   73.81%           
=======================================
  Files          64       64           
  Lines        7538     7504   -34     
=======================================
- Hits         5564     5539   -25     
+ Misses       1974     1965    -9     

@lcian lcian marked this pull request as ready for review November 24, 2025 09:10
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dead configuration option remains in public API

The extra_border_frames field in ClientOptions is no longer used anywhere after removing the backtrace trimming functionality, but it remains in the public API with documentation suggesting it has an effect. Users configuring this option will have their settings silently ignored, creating a confusing developer experience where the configuration appears valid but does nothing.

sentry-core/src/clientoptions.rs#L191-L194

pub session_mode: SessionMode,
/// Border frames which indicate a border from a backtrace to
/// useless internals. Some are automatically included.
pub extra_border_frames: Vec<&'static str>,

Fix in Cursor Fix in Web


@linear
Copy link

linear bot commented Nov 24, 2025

"sentry_core::",
"sentry_types::",
"sentry_backtrace::",
"sentry_tracing::",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having this would make a frame (that was previously trimmed away) belonging to sentry_tracing be marked as in-app when reporting errors through tracing::error, hence breaking grouping when done by the "in-app stack trace" algorithm.
This has been detected by my test matrix.

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think we can make the changelog a bit more human-readable though :)

@lcian lcian merged commit 9525735 into master Nov 24, 2025
19 checks passed
@lcian lcian deleted the lcian/feat/no-truncation branch November 24, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary SDK-side data truncation and rely on Relay for handling max length limits.

4 participants