Skip to content

ci: align stable and MSRV check/test coverage #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szokeasaurusrex wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −30
Open

ci: align stable and MSRV check/test coverage #989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 18 additions & 30 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,20 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
rust: [stable, 1.88.0]

name: Check feature permutations using Rust stable on ${{ matrix.os }}
name: Check feature permutations using Rust ${{ matrix.rust }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}

steps:
- name: Checkout sources
uses: actions/checkout@v4

- name: Install rust ${{ matrix.rust }} toolchain
run: |
rustup toolchain install ${{ matrix.rust }} --profile minimal --no-self-update
rustup default ${{ matrix.rust }}

- uses: Swatinem/rust-cache@v2

- name: Check all features
Expand Down Expand Up @@ -74,27 +80,9 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
rust: [stable, 1.88.0]

name: Test using Rust stable on ${{ matrix.os }}
runs-on: ${{ matrix.os }}

steps:
- name: Checkout sources
uses: actions/checkout@v4

- uses: Swatinem/rust-cache@v2

- name: Run cargo test
run: cargo test --workspace --all-features --all-targets

MSRV:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
rust: [1.88.0]

name: Check / Test MSRV on ${{ matrix.os }}
name: Test using Rust ${{ matrix.rust }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}

steps:
Expand All @@ -108,16 +96,16 @@ jobs:

- uses: Swatinem/rust-cache@v2

- name: Check sentry-core without default features
run: cargo check --no-default-features
working-directory: sentry-core
- name: Run cargo test
run: cargo test --workspace --all-features --all-targets

- name: Check default features
run: cargo check
- name: Run cargo doc tests
run: cargo test --workspace --all-features --doc

- name: Test sentry test feature
run: cargo test --features=test
working-directory: sentry
# Keep this separate so we continue asserting the default+test feature
# combination for sentry explicitly, even with broader all-features coverage.
- name: Test sentry default+test feature combination
run: cargo test -p sentry --features test

codecov:
name: Code Coverage
Expand Down Expand Up @@ -162,7 +150,7 @@ jobs:
if: ${{ always() }}
# Keep this list in sync with all CI jobs that should be required.
# `codecov` is intentionally excluded from this aggregator.
needs: [lints, check, test, MSRV, doc]
needs: [lints, check, test, doc]

steps:
- name: Fail if any required job did not succeed
Expand Down