feat: add ConsoleInputSerializer for console command arguments/options#1007
Merged
Litarnus merged 3 commits intogetsentry:masterfrom Apr 1, 2026
Merged
feat: add ConsoleInputSerializer for console command arguments/options#1007Litarnus merged 3 commits intogetsentry:masterfrom
Litarnus merged 3 commits intogetsentry:masterfrom
Conversation
Litarnus
reviewed
Mar 16, 2026
Contributor
Litarnus
left a comment
Litarnus
left a comment
There was a problem hiding this comment.
Looks good, can you add a small integration test to show that it properly resolves when added as serializer. Since we are not directly interacting with it, I think it would be good to have such a test so that it doesn't break silently if it ever gets renamed or moved or so
Contributor
Author
|
@Litarnus done! |
Verifies that ConsoleInputSerializer is registered in the service container and properly resolves as a Reference when configured as a class_serializer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sylfabre
force-pushed
the
console_input_serialiazer
branch
from
35ba2e8 to
e2c7ded
Compare
Contributor
Author
|
@Litarnus The CI is passing, but Warden: is there anything I can do here? |
Litarnus
approved these changes
Apr 1, 2026
Contributor
|
@sylfabre thanks for your contribution. Warden is not properly set up right now so we can just ignore this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tions
Description
This PR adds a
ConsoleInputSerializerto serialize console command arguments and options.It can be used like this:
Issues