Improve CI #54
Merged
Improve CI #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add PHP 7.1 - do not allow failure for 7.0 - cache only composer downloads, not info about lib versions - prefer to install dist version of dependencies - let the build fail for tests first, CS latter
Member
|
I think we were using Scrutinizer on the sentry-php repo, so probably good to be uniform |
dcramer
approved these changes
May 5, 2017
Contributor
Author
|
Ok great! I've added a minimal |
Member
|
just setup scrutinizer for this repo |
Contributor
Author
|
Great, thanks! I've excluded the examples folder from the analysis, and this latest push proved that the PR integration is working correctly! 👍 I'll merge this and later I will try to tackle some of the stuff that emerged from this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would also like to add some external quality/test coverage check tool, but that would require some intervention on the repo settings. Any preference? I like Scrutinizer, but we also have CodeClimate and many others... @dcramer it's up to you, I will gladly add the integration in this PR!