Conversation
…verridden in memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to be able to override stuff like
placement, but some things likesentryOrigincannot be overridden because that would cause the whole<ApiProxyContextProvider>to re-connect and be a weird experience.So we have the
<StaticConfigProvider>which wraps the whole app and nothing inside it can be changed.Then down below we have
<MutableConfigProvider>where the fields can be changed. If something below here depends on a field then it will be updated to use the new value. This means that fields likeplacementcan be updated without any problems, other fields likedebugandsentryOrigincan be updated, but nothing lower really uses them. This is a limitation that maybe we can address in a followup iteration.It's important is not to re-render
<ApiProxyContextProvider>or the other providers.