Skip to content

deps: Bump eslint dependencies#301

Merged
ryan953 merged 1 commit intomainfrom
ryan953/deps-eslint
Dec 30, 2025
Merged

deps: Bump eslint dependencies#301
ryan953 merged 1 commit intomainfrom
ryan953/deps-eslint

Conversation

@ryan953
Copy link
Copy Markdown
Member

@ryan953 ryan953 commented Dec 30, 2025

No description provided.

@ryan953 ryan953 requested a review from a team as a code owner December 30, 2025 17:11
@ryan953 ryan953 enabled auto-merge (squash) December 30, 2025 17:11
@ryan953 ryan953 merged commit e6a69d5 into main Dec 30, 2025
8 checks passed
@ryan953 ryan953 deleted the ryan953/deps-eslint branch December 30, 2025 17:12
Comment thread package.json
"@eslint/compat": "2.0.0",
"@eslint/eslintrc": "3.3.3",
"@eslint/js": "9.39.2",
"@sentry/vite-plugin": "^2.22.4",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @eslint/compat upgrade to 2.0.0 requires a newer Node.js version than what is declared in package.json, breaking the development environment for users on older Node versions.
Severity: HIGH | Confidence: High

🔍 Detailed Analysis

The project's package.json declares support for Node.js versions >=18. However, this pull request upgrades the @eslint/compat dependency to version 2.0.0, which requires Node.js ^20.19.0 || ^22.13.0 || >=24. This creates a conflict where developers using a supported but now incompatible Node version, such as Node 18, will encounter errors during pnpm install or when running linting scripts. This breaks the development workflow for anyone adhering to the project's stated minimum Node.js version.

💡 Suggested Fix

Align the project's declared Node.js support with its dependencies. Update the engines.node field in package.json to "^20.19.0 || ^22.13.0 || >=24" to reflect the new requirement from @eslint/compat@2.0.0.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L78

Potential issue: The project's `package.json` declares support for Node.js versions
`>=18`. However, this pull request upgrades the `@eslint/compat` dependency to version
`2.0.0`, which requires Node.js `^20.19.0 || ^22.13.0 || >=24`. This creates a conflict
where developers using a supported but now incompatible Node version, such as Node 18,
will encounter errors during `pnpm install` or when running linting scripts. This breaks
the development workflow for anyone adhering to the project's stated minimum Node.js
version.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8038169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant