-
-
Notifications
You must be signed in to change notification settings - Fork 58
fix: Replace ThreadPool with WorkerThread for background scope sync on Android
#2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bitsandfoxes
merged 6 commits into
feat/bump-net-6
from
fix/replace-android-async-scope-sync
Nov 19, 2025
Merged
fix: Replace ThreadPool with WorkerThread for background scope sync on Android
#2426
bitsandfoxes
merged 6 commits into
feat/bump-net-6
from
fix/replace-android-async-scope-sync
Nov 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mujacica
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2423
Problem
The SDK was experiencing
SIGSEGVcrashes in a native library when running on Android. It looked like the crashes occurred when native code attempted to use JNI on a background thread.Root Cause
SentryJavapreviously usedThreadPool.QueueUserWorkItemto perform scope sync operations on non-main threads. Per Unity's JNI documentation, threads must be explicitly attached to and detached from the JVM to use JNI.The previous approach (see in #2107 and #2215) was:
AndroidJNI.AttachCurrentThread()AndroidJNI.DetachCurrentThread()The Issue: In high-pressure environments,
ThreadPoolthreads seem to get aggressively reused. When Sentry detached a ThreadPool thread after its operation, that same thread could be immediately reassigned to other code (e.g., Azure SDK) and that thread still expected JNI to be available. This caused:AndroidJavaObject) to fail with "field not found" errors (locally reproducible)SIGSEGVwhen dereferencing null JNI pointersThe SDK has no way to know if a ThreadPool thread is already attached by other code, making safe attach/detach impossible in a shared thread pool environment.
Solution
Replace the ThreadPool-based approach with a dedicated worker thread that the SDK fully controls:
SentryJavaconstructor and disposed inClose()ConcurrentQueue<(Action, string)>withAutoResetEventfor work dispatch