This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Add errorHandler option#133
Merged
kamilogorek merged 1 commit intogetsentry:masterfrom Jul 30, 2019
palindrom615:master
Merged
Conversation
Closed
Contributor
|
Makes perfect sense, thanks for putting it together! |
This was referenced Jul 30, 2019
Contributor
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using on-premise version sentry on my workspace and it works amazingly except occasional build failure on CI server caused by a network issue.
#75, #100 and some more issues are complaining sentry error, and I guess they are suffered from a network limit like me. I cannot change my company's network policy, so, at least I need building my project with sentry release failure.
Sentry plugin is not a code processor and it does not directly affect the compiled code. It is plugin with side effect and IO, and there always is a possibility to fail regardless of the code itself. So, IMO it would be quite reasonable that users have the right to choose ignoring sentry plugin error.
I added
errorHandleroption. check-up, please?