Skip to content
This repository was archived by the owner on Nov 20, 2023. It is now read-only.

fix(deploy): change newDeploy to deploy#206

Merged
kamilogorek merged 1 commit intogetsentry:masterfrom
philibea:fix-deploy
Jul 20, 2020
Merged

fix(deploy): change newDeploy to deploy#206
kamilogorek merged 1 commit intogetsentry:masterfrom
philibea:fix-deploy

Conversation

@philibea
Copy link
Contributor

@philibea philibea commented Jul 17, 2020

related to #205

matthprost
matthprost approved these changes Jul 17, 2020
View reviewed changes
Copy link

@matthprost matthprost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@kamilogorek
Copy link
Contributor

kamilogorek commented Jul 17, 2020

It should modify mocked CLI instead, as the method is indeed called newDeploy - https://github.com/getsentry/sentry-cli/blob/master/js/releases/index.js#L196-L202

kamilogorek
kamilogorek suggested changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify L157 instead

@kamilogorek kamilogorek merged commit d695dcf into getsentry:master Jul 20, 2020
@kamilogorek
Copy link
Contributor

kamilogorek commented Jul 20, 2020

Thanks!

@matthprost matthprost mentioned this pull request Jul 20, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@kamilogorek kamilogorek kamilogorek requested changes

@matthprost matthprost matthprost approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philibea @kamilogorek @matthprost