Conversation
|
Aside if/when we land this change I will overhaul various docs, as we need quite a lot of cleanup here, and I want to find a way to embed the docs here onto docs.sentry.io (or clean up the legibility of them). |
|
If we are already adding these configurations, I'd like to have all of them here to be in sync with https://github.com/getsentry/sentry-cli/pull/830/files#diff-10c2a82e0a2d63a7ae98a99588002f9eR141-R161 |
|
do we actually need the others? maybe vcsRemote but Im not sure how it works dsn doesnt seem relevant? |
|
also no need to support apiKey here as its generally deprecated |
db1e11f to
2a03043
Compare
|
added vcsRemote - dsn is only for sending events so not needed here afaict |
2a03043 to
2e34681
Compare
|
@kamilogorek left you a note but could you ship a new sentry-cli to npm? its not obvious to me what steps id need to take to do it in a way where im not ruining something. I want to do that before merging this, and merging this is blocking fixing some docs. |
|
I'll merge this one, add missing vsc config assignment, bump sentry-cli version and release a new version of this package. |
|
Seems like these new parameters are missing from README.md. |
|
It doesn't seem to work. also missing from README |
|
Updated #238 |
This makes it possible to greatly simplify the user experience for customers trying to upload sourcemaps. We already install the sentry-cli via the npm package, but they were still required to setup a fairly cryptic configuration in addition to also having to setup configuration in the plugin itself for various things. This ensures they can configure the entirety of the process within the webpack plugin.
Requires getsentry/sentry-cli#830