Skip to content
This repository was archived by the owner on Nov 20, 2023. It is now read-only.

feat: Support minimal CLI options#225

Merged
kamilogorek merged 1 commit intomasterfrom
feat/cli-options
Sep 23, 2020
Merged

feat: Support minimal CLI options#225
kamilogorek merged 1 commit intomasterfrom
feat/cli-options

Conversation

@dcramer
Copy link
Member

@dcramer dcramer commented Sep 18, 2020

This makes it possible to greatly simplify the user experience for customers trying to upload sourcemaps. We already install the sentry-cli via the npm package, but they were still required to setup a fairly cryptic configuration in addition to also having to setup configuration in the plugin itself for various things. This ensures they can configure the entirety of the process within the webpack plugin.

Requires getsentry/sentry-cli#830

@dcramer
Copy link
Member Author

dcramer commented Sep 18, 2020

@dcramer
Copy link
Member Author

dcramer commented Sep 18, 2020

Aside if/when we land this change I will overhaul various docs, as we need quite a lot of cleanup here, and I want to find a way to embed the docs here onto docs.sentry.io (or clean up the legibility of them).

@kamilogorek
Copy link
Contributor

If we are already adding these configurations, I'd like to have all of them here to be in sync with https://github.com/getsentry/sentry-cli/pull/830/files#diff-10c2a82e0a2d63a7ae98a99588002f9eR141-R161

@dcramer
Copy link
Member Author

dcramer commented Sep 22, 2020

do we actually need the others? maybe vcsRemote but Im not sure how it works

dsn doesnt seem relevant?

@dcramer
Copy link
Member Author

dcramer commented Sep 22, 2020

also no need to support apiKey here as its generally deprecated

@dcramer
Copy link
Member Author

dcramer commented Sep 22, 2020

added vcsRemote - dsn is only for sending events so not needed here afaict

@dcramer
Copy link
Member Author

dcramer commented Sep 22, 2020

@kamilogorek left you a note but could you ship a new sentry-cli to npm? its not obvious to me what steps id need to take to do it in a way where im not ruining something. I want to do that before merging this, and merging this is blocking fixing some docs.

@kamilogorek
Copy link
Contributor

I'll merge this one, add missing vsc config assignment, bump sentry-cli version and release a new version of this package.

@kamilogorek kamilogorek merged commit 171d06a into master Sep 23, 2020
@kamilogorek kamilogorek deleted the feat/cli-options branch September 23, 2020 09:29
@modestfake
Copy link

Seems like these new parameters are missing from README.md.

@taejs
Copy link

taejs commented Nov 3, 2020

It doesn't seem to work. also missing from README

@kamilogorek
Copy link
Contributor

Updated #238

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants