Skip to content

feat(react-native): skip patch native files when expo CNG#1211

Merged
antonis merged 6 commits intogetsentry:masterfrom
uragirii:feat/expo-cng-check
Feb 11, 2026
Merged

feat(react-native): skip patch native files when expo CNG#1211
antonis merged 6 commits intogetsentry:masterfrom
uragirii:feat/expo-cng-check

Conversation

@uragirii
Copy link
Contributor

@uragirii uragirii commented Feb 8, 2026

Description

  • Adds check to see if you are in Expo CNG to skip the native file patching
  • Checks if ios and android folders are in .gitignore
  • Skips the step and prints a log to show that step is skipped
  • Added Sentry tracking for this
  • As this is my first contribution, please let me know if I missed something
image

AI Disclosure

  • The tests in this PR are written by Claude Code Sonnet 4.5.
  • Actual implemention of the feature is done by me, only *.test.ts files are generated based on my code

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 72.88136% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.32%. Comparing base (51bb31c) to head (d0005c2).
⚠️ Report is 57 commits behind head on master.

Files with missing lines Patch % Lines
src/react-native/react-native-wizard.ts 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
+ Coverage   36.26%   37.32%   +1.06%     
==========================================
  Files         144      154      +10     
  Lines       17746    18585     +839     
  Branches     1457     1558     +101     
==========================================
+ Hits         6435     6937     +502     
- Misses      11291    11628     +337     
  Partials       20       20              
Flag Coverage Δ
unit-tests 37.32% <72.88%> (+1.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @uragirii thanks for opening this PR! I started CI to run our tests and lint jobs. Pretty sure there are still some formatting issues.

From my PoV the actual changes look good. Also gonna ask @antonis to take a look, as my ReactNative/Expo knowledge is very limited :D

@antonis antonis requested review from alwx and antonis February 9, 2026 10:06
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @uragirii 🙇 Overall it looks great 🥇

I've left a few comments for possible improvements along with the sentry[bot] feedback.

We could also add a changelog entry. Something like:

  ## Unreleased

  - fix(react-native): Skip native file patching when Expo CNG is detected ([#1211](https://github.com/getsentry/sentry-wizard/pull/1211))

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@uragirii
Copy link
Contributor Author

Can someone run the ubuntu test CI again? It failed due to 500 from yarn install

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for your contribution @uragirii 🙇
I think after fixing the variable name for clarity we are ready to 🚢 🎉

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @uragirii 🥇
Thank you for identifying this issue and fixing it 🚀

@antonis antonis merged commit 5c5532c into getsentry:master Feb 11, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants