feat(react-native): skip patch native files when expo CNG#1211
feat(react-native): skip patch native files when expo CNG#1211antonis merged 6 commits intogetsentry:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1211 +/- ##
==========================================
+ Coverage 36.26% 37.32% +1.06%
==========================================
Files 144 154 +10
Lines 17746 18585 +839
Branches 1457 1558 +101
==========================================
+ Hits 6435 6937 +502
- Misses 11291 11628 +337
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
antonis
left a comment
There was a problem hiding this comment.
Thank you for your contribution @uragirii 🙇 Overall it looks great 🥇
I've left a few comments for possible improvements along with the sentry[bot] feedback.
We could also add a changelog entry. Something like:
## Unreleased
- fix(react-native): Skip native file patching when Expo CNG is detected ([#1211](https://github.com/getsentry/sentry-wizard/pull/1211))
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
Can someone run the ubuntu test CI again? It failed due to 500 from yarn install |
antonis
left a comment
There was a problem hiding this comment.
Thank you again for your contribution @uragirii 🙇
I think after fixing the variable name for clarity we are ready to 🚢 🎉
Description
AI Disclosure