feat(react-router): Switch to new stable instrumentations api#1265
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f26141b. Configure here.
| id && | ||
| id.type === 'Identifier' && | ||
| (id.name === 'instrumentations' || | ||
| id.name === 'unstable_instrumentations') |
There was a problem hiding this comment.
Legacy export blocks migration
Medium Severity
The instrumentInstrumentations function incorrectly treats the legacy unstable_instrumentations export as the new instrumentations export. This prevents the codemod from adding the correct instrumentations export when rerun, disabling server-side loader/action instrumentation for React Router >=7.15.0 apps.
Reviewed by Cursor Bugbot for commit f26141b. Configure here.
| return addPropToHydratedRouter( | ||
| ast, | ||
| 'unstable_instrumentations', | ||
| 'instrumentations', |
There was a problem hiding this comment.
Client legacy prop remains stale
Medium Severity
addInstrumentationPropsToHydratedRouter only adds the stable instrumentations prop and never migrates existing unstable_instrumentations. Existing Sentry-instrumented apps keep the legacy prop after rerunning the wizard, so React Router >=7.15.0 will miss client-side instrumentation.
Reviewed by Cursor Bugbot for commit f26141b. Configure here.
2 participants
The api became stable in https://reactrouter.com/changelog#v7150, so we just bump the version guard and use the stable variant.
ref getsentry/sentry-javascript#20690