fix(angular): Fix source map generation bugs#963
Merged
Lms24 merged 8 commits intoonur/angular-wizard-basefrom Apr 16, 2025
Merged
fix(angular): Fix source map generation bugs#963Lms24 merged 8 commits intoonur/angular-wizard-basefrom
Lms24 merged 8 commits intoonur/angular-wizard-basefrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## onur/angular-wizard-base #963 +/- ##
============================================================
- Coverage 23.14% 23.09% -0.05%
============================================================
Files 126 126
Lines 13516 13543 +27
Branches 718 718
============================================================
Hits 3128 3128
- Misses 10367 10394 +27
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lforst
approved these changes
Apr 16, 2025
Lms24
force-pushed
the
onur/angular-wizard-base
branch
from
674fd03 to
c27f532
Compare
Lms24
force-pushed
the
lms/fix-angular-sourcemap-generation
branch
from
a50567d to
d88cd25
Compare
onurtemizkan
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/sourcemaps/tools/sentry-cli.ts:24
- [nitpick] Type names should follow PascalCase conventions in TypeScript. Consider renaming 'configureSentryCLIOptions' to 'ConfigureSentryCLIOptions'.
type configureSentryCLIOptions = SourceMapUploadToolConfigurationOptions & {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Apr 17, 2025
Lms24
added a commit
that referenced
this pull request
Apr 22, 2025
- avoid crash when reading `angular.json` fails - fixed bug where we'd remove production config in `angular.json` - added reporting of read/write file errors to Sentry - added a bunch of tests for `angular.json` manipulation - fixed a bunch of lint and TS errors by introducing a defensively typed `PartialAngularJson` type
Lms24
added a commit
that referenced
this pull request
Apr 22, 2025
* feat(angular): Add Angular menu option and install SDK (#765) Adds Angular menu option with SDK installation --------- Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com> * Add CHANGELOG entry. * feat(angular): Add Sentry setup in `main.ts` (#768) - Adds Sentry initialization on main.ts with feature selection - Also adds Prettier run * feat(angular): Add Sentry setup in App Config (#769) * feat(angular): Add Sentry setup in App Config * Use `hasSentryContent` from `ast-utils` * Bail out if `app-config` is not under pre-defined location * feat(angular): Configure source map upload. (#770) * feat(angular): Configure source map upload. * Use `preSelectedProject` as is * Fix * test(angular): Add E2E tests. (#780) * switch tests to vitest * fix missing new options * ref(angular): Fix eslint errors and failing e2e test (#964) * fix(angular): Fix source map generation bugs (#963) - avoid crash when reading `angular.json` fails - fixed bug where we'd remove production config in `angular.json` - added reporting of read/write file errors to Sentry - added a bunch of tests for `angular.json` manipulation - fixed a bunch of lint and TS errors by introducing a defensively typed `PartialAngularJson` type * .gitignore .envrc * test(angular): Add tests for enabling source maps generation (#968) * feat(angular): Add example component (#953) See PR description for details * feat(angular): Check for min compatible Angular version with wizard setup (#970) --------- Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com> Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #953, I noticed that our source map generation flow has some bugs that we should fix:
angular.jsonfailsangular.jsonangular.jsonmanipulationPartialAngularJsontype#skip-changelog