Fix size analysis tag nullability and manual select_related

cursoragent · cursoragent · commit 067ecdfead66 · 2026-03-17T14:56:33.000Z
diff --git a/src/sentry/preprod/size_analysis/grouptype.py b/src/sentry/preprod/size_analysis/grouptype.py
@@ -61,7 +61,8 @@ def _artifact_to_tags(artifact: PreprodArtifact) -> dict[str, str]:
     commit_comparison = artifact.commit_comparison
     if commit_comparison is not None:
         tags["commit_sha"] = commit_comparison.head_sha
-        tags["branch"] = commit_comparison.head_ref
+        if commit_comparison.head_ref is not None:
+            tags["branch"] = commit_comparison.head_ref
         tags["repo"] = commit_comparison.head_repo_name
         if commit_comparison.base_sha:
             tags["base_sha"] = commit_comparison.base_sha
diff --git a/src/sentry/preprod/size_analysis/tasks.py b/src/sentry/preprod/size_analysis/tasks.py
@@ -326,6 +326,7 @@ def manual_size_analysis_comparison(
         )
         .select_related("preprod_artifact")
         .select_related("preprod_artifact__mobile_app_info")
+        .select_related("preprod_artifact__commit_comparison")
     )
     head_size_metrics = list(head_size_metrics_qs)
 
@@ -337,6 +338,7 @@ def manual_size_analysis_comparison(
         )
         .select_related("preprod_artifact")
         .select_related("preprod_artifact__mobile_app_info")
+        .select_related("preprod_artifact__commit_comparison")
     )
     base_size_metrics = list(base_size_metrics_qs)
 

Original file line number	Diff line number	Diff line change
`@@ -326,6 +326,7 @@ def manual_size_analysis_comparison(`
`326`	`326`	`)`
`327`	`327`	`.select_related("preprod_artifact")`
`328`	`328`	`.select_related("preprod_artifact__mobile_app_info")`
	`329`	`+ .select_related("preprod_artifact__commit_comparison")`
`329`	`330`	`)`
`330`	`331`	`head_size_metrics = list(head_size_metrics_qs)`
`331`	`332`
`@@ -337,6 +338,7 @@ def manual_size_analysis_comparison(`
`337`	`338`	`)`
`338`	`339`	`.select_related("preprod_artifact")`
`339`	`340`	`.select_related("preprod_artifact__mobile_app_info")`
	`341`	`+ .select_related("preprod_artifact__commit_comparison")`
`340`	`342`	`)`
`341`	`343`	`base_size_metrics = list(base_size_metrics_qs)`
`342`	`344`