fix(integrations): User is None (#28955)

Author: mgaeta

src/sentry/db/models/manager/base_query_set.py

@@ -17,7 +17,9 @@ def using_replica(self) -> "BaseQuerySet":
         Use read replica for this query. Database router is expected to use the
         `replica=True` hint to make routing decision.
         """
-        return self.using(router.db_for_read(self.model, replica=True))
+        # Explicitly typing to satisfy mypy.
+        query_set: "BaseQuerySet" = self.using(router.db_for_read(self.model, replica=True))
+        return query_set
 
     def defer(self, *args: Any, **kwargs: Any) -> "BaseQuerySet":
         raise NotImplementedError("Use ``values_list`` instead [performance].")

src/sentry/integrations/example/integration.py

@@ -1,3 +1,5 @@
+from typing import Any, Optional
+
 from django.http import HttpResponse
 
 from sentry.integrations import (
@@ -9,7 +11,7 @@
 )
 from sentry.integrations.issues import IssueSyncMixin
 from sentry.mediators.plugins import Migrator
-from sentry.models import User
+from sentry.models import ExternalIssue, User
 from sentry.pipeline import PipelineView
 from sentry.shared_integrations.exceptions import IntegrationError
 
@@ -127,7 +129,13 @@ def get_repositories(self):
     def get_unmigratable_repositories(self):
         return []
 
-    def sync_assignee_outbound(self, external_issue, user, assign=True, **kwargs):
+    def sync_assignee_outbound(
+        self,
+        external_issue: "ExternalIssue",
+        user: Optional["User"],
+        assign: bool = True,
+        **kwargs: Any,
+    ) -> None:
         pass
 
     def sync_status_outbound(self, external_issue, is_resolved, project_id):

src/sentry/integrations/issues.py

@@ -1,8 +1,9 @@
 import logging
 from collections import defaultdict
+from typing import Any, Optional
 
 from sentry import features
-from sentry.models import ExternalIssue, Group, GroupLink, GroupStatus, Organization
+from sentry.models import ExternalIssue, Group, GroupLink, GroupStatus, Organization, User
 from sentry.models.useroption import UserOption
 from sentry.shared_integrations.exceptions import ApiError, IntegrationError
 from sentry.types.activity import ActivityType
@@ -306,7 +307,13 @@ def should_sync(self, attribute: str) -> bool:
         value: bool = self.org_integration.config.get(key, False)
         return value
 
-    def sync_assignee_outbound(self, external_issue, user, assign=True, **kwargs):
+    def sync_assignee_outbound(
+        self,
+        external_issue: "ExternalIssue",
+        user: Optional["User"],
+        assign: bool = True,
+        **kwargs: Any,
+    ) -> None:
         """
         Propagate a sentry issue's assignee to a linked issue's assignee.
         If assign=True, we're assigning the issue. Otherwise, deassign.

src/sentry/integrations/jira/integration.py

@@ -1,6 +1,7 @@
 import logging
 import re
 from operator import attrgetter
+from typing import Any, Optional
 
 from django.conf import settings
 from django.urls import reverse
@@ -15,7 +16,13 @@
     IntegrationProvider,
 )
 from sentry.integrations.issues import IssueSyncMixin
-from sentry.models import IntegrationExternalProject, Organization, OrganizationIntegration, User
+from sentry.models import (
+    ExternalIssue,
+    IntegrationExternalProject,
+    Organization,
+    OrganizationIntegration,
+    User,
+)
 from sentry.shared_integrations.exceptions import (
     ApiError,
     ApiUnauthorized,
@@ -827,14 +834,20 @@ def create_issue(self, data, **kwargs):
         # Immediately fetch and return the created issue.
         return self.get_issue(issue_key)
 
-    def sync_assignee_outbound(self, external_issue, user, assign=True, **kwargs):
+    def sync_assignee_outbound(
+        self,
+        external_issue: "ExternalIssue",
+        user: Optional["User"],
+        assign: bool = True,
+        **kwargs: Any,
+    ) -> None:
         """
         Propagate a sentry issue's assignee to a jira issue's assignee
         """
         client = self.get_client()
 
         jira_user = None
-        if assign:
+        if user and assign:
             for ue in user.emails.filter(is_verified=True):
                 try:
                     possible_users = client.search_users_for_issue(external_issue.key, ue.email)
@@ -873,7 +886,7 @@ def sync_assignee_outbound(self, external_issue, user, assign=True, **kwargs):
                 extra={
                     "organization_id": external_issue.organization_id,
                     "integration_id": external_issue.integration_id,
-                    "user_id": user.id,
+                    "user_id": user.id if user else None,
                     "issue_key": external_issue.key,
                 },
             )

src/sentry/integrations/vsts/issues.py

@@ -208,12 +208,16 @@ def get_issue(self, issue_id: str, **kwargs: Any) -> Mapping[str, Any]:
         }
 
     def sync_assignee_outbound(
-        self, external_issue: "ExternalIssue", user: User, assign: bool = True, **kwargs: Any
+        self,
+        external_issue: "ExternalIssue",
+        user: Optional["User"],
+        assign: bool = True,
+        **kwargs: Any,
     ) -> None:
         client = self.get_client()
         assignee = None
 
-        if assign is True:
+        if user and assign is True:
             sentry_emails = [email.email.lower() for email in user.get_verified_emails()]
             continuation_token = None
             while True:
@@ -247,7 +251,7 @@ def sync_assignee_outbound(
                 "vsts.failed-to-assign",
                 extra={
                     "integration_id": external_issue.integration_id,
-                    "user_id": user.id,
+                    "user_id": user.id if user else None,
                     "issue_key": external_issue.key,
                 },
             )