Skip to content

Conversation

ameliahsu
Copy link
Member

since we've changed the trigger condition options, all of the new conditions conflict when using the "all" logic type, and only the "any" logic type can be used

Google Keep Note

therefore, we only want the "all" logic type to be available if the automation has already selected it previously (this is only possible if it was migrated from an issue alert rule)

when creating a new automation or editing an existing automation that has the "any" logic type:

Screenshot 2025-10-01 at 11 51 43 AM

when editing an existing automation that has the "all" logic type:
Screenshot 2025-10-01 at 11 52 22 AM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 1, 2025
@ameliahsu ameliahsu marked this pull request as ready for review October 1, 2025 21:32
@ameliahsu ameliahsu requested a review from a team as a code owner October 1, 2025 21:32

export const AutomationBuilderContext = createContext<{
actions: AutomationActions;
showTriggerLogicTypeSelector: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment here might help

@ameliahsu ameliahsu merged commit 644f987 into master Oct 15, 2025
46 checks passed
@ameliahsu ameliahsu deleted the mia/aci/dont-show-trigger-logic-selector branch October 15, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants