feat(uptime): have results consumer disable disallowed uptime detectors #100996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #100996 +/- ##
===========================================
+ Coverage 80.44% 81.03% +0.58%
===========================================
Files 8700 8700
Lines 385889 385898 +9
Branches 24402 24402
===========================================
+ Hits 310438 312718 +2280
+ Misses 75100 72829 -2271
Partials 351 351 |
wedamija
approved these changes
Oct 10, 2025
| if result["status"] == CHECKSTATUS_DISALLOWED_BY_ROBOTS: | ||
| try: | ||
| detector = get_detector(subscription) | ||
| logger.info("disallowed_by_robots", extra=result) |
Member
There was a problem hiding this comment.
Might also be worth including this as a metrics.incr like we have elsewhere, for example:
metrics.incr(
"uptime.result_processor.subscription_not_found",
sample_rate=1.0,
tags={"uptime_region": result.get("region", "default")},
)
It'd be good to have something like that here too
wedamija
reviewed
Oct 10, 2025
| logger.info("disallowed_by_robots", extra=result) | ||
| disable_uptime_detector(detector) | ||
| except Exception as e: | ||
| logger.info("disallowed_by_robots.error", extra={"error": e, "result": result}) |
Member
There was a problem hiding this comment.
I think we should use logger.exception here so that we see this in sentry
klochek
force-pushed
the
christopherklochek/new-553-allow-results_consumer-to-disable-checks-for-domains-with-a
branch
from
a6e8554 to
9d513b3
Compare
klochek
deleted the
christopherklochek/new-553-allow-results_consumer-to-disable-checks-for-domains-with-a
branch
chromy
pushed a commit
that referenced
this pull request
Oct 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.