chore(flags): rm feature flag cta from FE #101015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
commented
Oct 6, 2025
| @@ -0,0 +1,118 @@ | |||
| import {Fragment, useEffect} from 'react'; | |||
Member
Author
There was a problem hiding this comment.
this file was just renamed from the inline CTA file, but now it exports the FeatureFlagCTAContent component by default
michellewzhang
commented
Oct 6, 2025
Comment on lines
-223
to
-241
| it('renders cta if event.contexts.flags is not set and should show cta', async () => { | ||
| const org = OrganizationFixture({features: ['feature-flag-cta']}); | ||
| it('renders empty state if event.contexts.flags is not set - flags already sent', () => { | ||
| const org = OrganizationFixture({features: []}); | ||
|
|
||
| render(<EventFeatureFlagSection {...NO_FLAG_CONTEXT_SECTION_PROPS_CTA} />, { | ||
| render(<EventFeatureFlagSection {...NO_FLAG_CONTEXT_WITH_FLAGS_SECTION_PROPS} />, { | ||
| organization: org, | ||
| }); | ||
|
|
||
| const control = screen.queryByRole('button', {name: 'Sort Flags'}); | ||
| expect(control).not.toBeInTheDocument(); | ||
| const search = screen.queryByRole('button', {name: 'Open Feature Flag Search'}); | ||
| expect(search).not.toBeInTheDocument(); | ||
| expect( | ||
| screen.queryByRole('button', {name: 'Set Up Integration'}) | ||
| ).not.toBeInTheDocument(); | ||
|
|
||
| // wait for the CTA to be rendered | ||
| expect(await screen.findByText('Set Up Feature Flags')).toBeInTheDocument(); | ||
| expect(screen.getByText('Feature Flags')).toBeInTheDocument(); | ||
| }); |
Member
Author
There was a problem hiding this comment.
this test is not needed
michellewzhang
commented
Oct 6, 2025
Comment on lines
-287
to
-305
| it('renders nothing if event.contexts.flags is not set and should not show cta - no feature flag', async () => { | ||
| const org = OrganizationFixture({features: ['fake-feature-flag']}); | ||
| it('renders nothing if event.contexts.flags is not set - wrong platform', () => { | ||
| const org = OrganizationFixture({features: []}); | ||
|
|
||
| render(<EventFeatureFlagSection {...NO_FLAG_CONTEXT_SECTION_PROPS_CTA} />, { | ||
| render(<EventFeatureFlagSection {...NO_FLAG_CONTEXT_SECTION_PROPS} />, { | ||
| organization: org, | ||
| }); | ||
|
|
||
| const control = screen.queryByRole('button', {name: 'Sort Flags'}); | ||
| expect(control).not.toBeInTheDocument(); | ||
| const search = screen.queryByRole('button', {name: 'Open Feature Flag Search'}); | ||
| expect(search).not.toBeInTheDocument(); | ||
| expect( | ||
| screen.queryByRole('button', {name: 'Set Up Integration'}) | ||
| ).not.toBeInTheDocument(); | ||
|
|
||
| // CTA should not appear | ||
| await waitFor(() => { | ||
| expect(screen.queryByText('Set Up Feature Flags')).not.toBeInTheDocument(); | ||
| }); |
billyvg
approved these changes
Oct 14, 2025
chromy
pushed a commit
that referenced
this pull request
Oct 17, 2025
rm the feature flag CTA (was only ever shown to LD users)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rm the feature flag CTA (was only ever shown to LD users)