Skip to content

Conversation

@ArthurKnaus
Copy link
Member

Remove usage of the organization:mcp-insights feature flag.

@ArthurKnaus ArthurKnaus requested review from a team as code owners October 7, 2025 20:22
@linear
Copy link

linear bot commented Oct 7, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 7, 2025
}) {
const organization = useOrganization();
if (!hasMCPInsightsFeature(organization) && getIsMCPNode(node)) {
if (!getIsMCPNode(node)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: MCP Section Visibility Logic Error

The conditional logic for rendering MCP sections was inverted. The The original code hid MCP sections when the feature was disabled and the node was an MCP node. The new logic if (!getIsMCPNode(node)) now hides non-MCP sections, causing MCP sections to always render regardless of the feature flag status. This changes the intended conditional visibility.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original logic was wrong

@ArthurKnaus ArthurKnaus merged commit b3ac1fa into master Oct 8, 2025
48 checks passed
@ArthurKnaus ArthurKnaus deleted the aknaus/ref/mcp-insights/remove-feature-flag-usage branch October 8, 2025 07:56
ArthurKnaus added a commit that referenced this pull request Oct 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants