Skip to content

ref(agents-insights): Remove feature flag registrations #101111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

ref(agents-insights): Remove feature flag registrations #101111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/sentry/features/temporary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,6 @@ def register_temporary_features(manager: FeatureManager) -> None:
manager.add("organizations:more-slow-alerts", OrganizationFeature, FeatureHandlerStrategy.INTERNAL, api_expose=False)
# Enable higher limit for workflows
manager.add("organizations:more-workflows", OrganizationFeature, FeatureHandlerStrategy.INTERNAL, api_expose=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: Removing the organizations:mcp-insights feature flag registration will cause all frontend checks to fail, making the entire MCP feature set inaccessible.

  • Description: The removal of the organizations:mcp-insights feature flag registration will cause all frontend checks for this flag, such as in the hasMCPInsightsFeature function, to consistently return false. This will make the MCP module invisible in the Insights UI, block access to the main MCP overview page by rendering a NoAccess component, and prevent MCP-specific details from appearing in trace views. The cumulative effect is that the entire MCP feature set will become inaccessible to all users, which is contrary to the presumed intent of graduating the feature.

  • Suggested fix: To correctly graduate the feature, all frontend code that checks for the mcp-insights flag should be updated. This includes removing the checks from components like McpInsightsFeature, functions like hasMCPInsightsFeature, and dependency maps like MODULE_FEATURE_VISIBLE_MAP. The code should be modified to make MCP features unconditionally available before the flag registration is removed.
    severity: 0.85, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

# Enable AI Agents specific insights
manager.add("organizations:agents-insights", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable MCP specific insights
manager.add("organizations:mcp-insights", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Extract on demand metrics
manager.add("organizations:on-demand-metrics-extraction", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Extract on demand metrics (experimental features)
Expand Down
Loading