Skip to content

feat(billing): add ondemand items to cart and receipt #101376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

feat(billing): add ondemand items to cart and receipt #101376

merged 1 commit into from
Oct 14, 2025

Conversation

@brendanhsentry
Copy link
Member

@brendanhsentry brendanhsentry commented Oct 10, 2025 •
edited
Loading

Screenshot 2025-10-10 at 1 43 32 PM Screenshot 2025-10-10 at 11 27 32 AM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 10, 2025
@brendanhsentry brendanhsentry marked this pull request as ready for review October 10, 2025 20:53
@brendanhsentry brendanhsentry requested a review from a team as a code owner October 10, 2025 20:53
vbro
vbro approved these changes Oct 11, 2025
View reviewed changes
Copy link
Contributor

@vbro vbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nit: can the amount be shortened, e.g. 4.9M errors, 187 GB attachments? The exact amount is always available in the PDF receipt.

@brendanhsentry brendanhsentry merged commit 6a0e530 into master Oct 14, 2025
46 checks passed
@brendanhsentry brendanhsentry deleted the brendan/od-items-in-cart-receipt branch October 14, 2025 15:50
chromy pushed a commit that referenced this pull request Oct 17, 2025
@brendanhsentry @chromy
feat(billing): add ondemand items to cart and receipt (#101376)
8da6b0b 
<img width="469" height="716" alt="Screenshot 2025-10-10 at 1 43 32 PM"
src="https://github.com/user-attachments/assets/6b92d745-585c-46bd-b225-eafdad30f017"
/>

<img width="854" height="1652" alt="Screenshot 2025-10-10 at 11 27
32 AM"
src="https://github.com/user-attachments/assets/f6aa6082-bb6e-4b5a-a95c-c8b340d87283"
/>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dashed dashed dashed approved these changes

@vbro vbro vbro approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brendanhsentry @dashed @vbro