feat(trace-view): format dollars #101423
Merged
feat(trace-view): format dollars #101423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
…h-cost-calculation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }, | ||
| [SpanFields.GEN_AI_USAGE_TOTAL_COST]: (props: CustomRenderersProps) => { | ||
| return formatDollars(+Number(props.item.value).toFixed(10)); | ||
| }, |
Contributor
There was a problem hiding this comment.
Bug: Precision Loss in AI Cost Renderers
The AI cost custom renderers use toFixed(10) for precision, but the unary + operator immediately converts the result back to a number. This reintroduces floating point precision issues and removes trailing zeros, undermining the goal of accurate cost display.
| GEN_AI_TOOL_NAME = 'gen_ai.tool.name', | ||
| GEN_AI_COST_INPUT_TOKENS = 'gen_ai.cost.input_tokens', | ||
| GEN_AI_COST_OUTPUT_TOKENS = 'gen_ai.cost.output_tokens', | ||
| GEN_AI_COST_TOTAL_TOKENS = 'gen_ai.cost.total_tokens', |
Contributor
There was a problem hiding this comment.
Bug: Missing AI Cost Fields in Number Fields
The new GEN_AI_COST_INPUT_TOKENS, GEN_AI_COST_OUTPUT_TOKENS, and GEN_AI_COST_TOTAL_TOKENS fields are in SpanFields but missing from SpanNumberFields. These are numeric cost values, like GEN_AI_USAGE_TOTAL_COST, and are typically formatted as dollars.
obostjancic
deleted the
ogi/tet-1256-fix-floating-point-issues-with-cost-calculation
branch
chromy
pushed a commit
that referenced
this pull request
Oct 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes TET-1256: Fix floating point issues with cost calculation