fix(sub v3): Correct percent calc for byte/hour categories #101429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ? prepaid * GIGABYTE | ||
| : isContinuousProfiling(category) | ||
| ? prepaid * MILLISECONDS_IN_HOUR | ||
| : prepaid; |
Contributor
There was a problem hiding this comment.
Bug: Incorrect Calculation of Reserved Total
The reservedTotal calculation now relies solely on prepaid, which often defaults to zero or doesn't include the reserved and free amounts. This results in an incorrect denominator for percentage calculations, potentially causing division by zero or displaying an inaccurate usage percentage to users.
Member
Author
There was a problem hiding this comment.
prepaid is made up of reserved and free on the backend
zero division is not a problem since we only call getPercentage if reservedTotal is truthy
vbro
approved these changes
Oct 14, 2025
chromy
pushed a commit
that referenced
this pull request
Oct 17, 2025
# before <img width="403" height="509" alt="Screenshot 2025-10-14 at 10 10 46 AM" src="https://github.com/user-attachments/assets/acb4dd30-a9bb-482f-9d8c-0cf260ef1e40" /> # after <img width="420" height="491" alt="Screenshot 2025-10-14 at 10 10 35 AM" src="https://github.com/user-attachments/assets/eee79083-49fc-41be-878b-c6e7875bd607" />
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after