Skip to content

Conversation

@isabellaenriquez
Copy link
Member

  • Removed the Trial available tag as it was redundant with the trial starter button
  • Moved the x days left tag to the same column as the trial starter button
  • Renamed column key to be more accurate to column contents
Screenshot 2025-10-14 at 10 20 52 AM

@isabellaenriquez isabellaenriquez requested a review from a team as a code owner October 14, 2025 14:21
@linear
Copy link

linear bot commented Oct 14, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 14, 2025
cursor[bot]

This comment was marked as outdated.

Comment on lines 205 to 211
!column.key.endsWith('Spend') ||
((subscription.onDemandInvoiced || subscription.onDemandInvoicedManual) &&
column.key === 'budgetSpend')) &&
(hasAnyPotentialProductTrial || column.key !== 'cta')
(hasAnyPotentialProductTrial || column.key !== 'trialInfo')
);
}, [
hasBillingPerms,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The trialInfo column is hidden when only active trials exist, as the visibility check incorrectly looks for only non-started trials.
  • Description: The visibility of the trialInfo column is controlled by the hasAnyPotentialProductTrial flag. This flag is true only if there is at least one trial that has not started (!trial.isStarted). If a user's subscription only contains trials that have already started, hasAnyPotentialProductTrial will be false, causing the column filtering logic to remove the trialInfo column from the table. This prevents the user from seeing the remaining duration for their active trials, such as the "X days left" tag.

  • Suggested fix: Modify the hasAnyPotentialProductTrial variable to check for the existence of any product trials, not just non-started ones. Change the condition from subscription.productTrials?.some(trial => !trial.isStarted) to subscription.productTrials && subscription.productTrials.length > 0. This will ensure the trialInfo column is displayed whenever there are trials, whether active or potential.
    severity: 0.55, confidence: 0.98

Did we get this right? 👍 / 👎 to inform future reviews.

cursor[bot]

This comment was marked as outdated.

@isabellaenriquez isabellaenriquez merged commit 0ed614e into master Oct 14, 2025
45 checks passed
@isabellaenriquez isabellaenriquez deleted the isabella/bil-1668 branch October 14, 2025 16:50
chromy pushed a commit that referenced this pull request Oct 17, 2025
- Removed the `Trial available` tag as it was redundant with the trial
starter button
- Moved the `x days left` tag to the same column as the trial starter
button
- Renamed column key to be more accurate to column contents

<img width="1350" height="732" alt="Screenshot 2025-10-14 at 10 20
52 AM"
src="https://github.com/user-attachments/assets/ba523f61-05b3-4217-85b7-ea4fa79a6a2f"
/>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants