-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(sub v3): Consolidate trial info in Usage Overview #101430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| !column.key.endsWith('Spend') || | ||
| ((subscription.onDemandInvoiced || subscription.onDemandInvoicedManual) && | ||
| column.key === 'budgetSpend')) && | ||
| (hasAnyPotentialProductTrial || column.key !== 'cta') | ||
| (hasAnyPotentialProductTrial || column.key !== 'trialInfo') | ||
| ); | ||
| }, [ | ||
| hasBillingPerms, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential bug: The trialInfo column is hidden when only active trials exist, as the visibility check incorrectly looks for only non-started trials.
-
Description: The visibility of the
trialInfocolumn is controlled by thehasAnyPotentialProductTrialflag. This flag istrueonly if there is at least one trial that has not started (!trial.isStarted). If a user's subscription only contains trials that have already started,hasAnyPotentialProductTrialwill befalse, causing the column filtering logic to remove thetrialInfocolumn from the table. This prevents the user from seeing the remaining duration for their active trials, such as the "X days left" tag. -
Suggested fix: Modify the
hasAnyPotentialProductTrialvariable to check for the existence of any product trials, not just non-started ones. Change the condition fromsubscription.productTrials?.some(trial => !trial.isStarted)tosubscription.productTrials && subscription.productTrials.length > 0. This will ensure thetrialInfocolumn is displayed whenever there are trials, whether active or potential.
severity: 0.55, confidence: 0.98
Did we get this right? 👍 / 👎 to inform future reviews.
- Removed the `Trial available` tag as it was redundant with the trial starter button - Moved the `x days left` tag to the same column as the trial starter button - Renamed column key to be more accurate to column contents <img width="1350" height="732" alt="Screenshot 2025-10-14 at 10 20 52 AM" src="https://github.com/user-attachments/assets/ba523f61-05b3-4217-85b7-ea4fa79a6a2f" />
Trial availabletag as it was redundant with the trial starter buttonx days lefttag to the same column as the trial starter button