Skip to content

Conversation

nikkikapadia
Copy link
Member

To display more cohesive warning messaging for dropped fields in the frontend we're changing the way dropped fields are being passed back for orderbys. We are changing it to mimic the columns and equations fields where the reason can be a list of fields that were dropped as part of the orderby.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 14, 2025
@nikkikapadia nikkikapadia marked this pull request as ready for review October 14, 2025 20:06
@nikkikapadia nikkikapadia requested a review from a team as a code owner October 14, 2025 20:06
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/sentry/discover/translation/mep_to_eap.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #101466    +/-   ##
=========================================
  Coverage   81.02%    81.03%            
=========================================
  Files        8701      8703     +2     
  Lines      386018    386247   +229     
  Branches    24409     24409            
=========================================
+ Hits       312777    312991   +214     
- Misses      72890     72905    +15     
  Partials      351       351            

@nikkikapadia nikkikapadia merged commit 7b4f672 into master Oct 15, 2025
66 checks passed
@nikkikapadia nikkikapadia deleted the nikki/fix/dropped-fields-format branch October 15, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants