Skip to content

Conversation

@scttcper
Copy link
Member

Try to point people towards the router returned from render, has no use in the new test environment.

Try to point people towards the router returned from render, has no use in the new test environment.
@scttcper scttcper requested a review from a team October 14, 2025 23:29
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12177 1 12176 10
View the top 1 failed test(s) by shortest run time
useReplayData should incrementally load attachments and errors
Stack Traces | 1.45s run time
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  -  2
+ Received  + 31

@@ -1,6 +1,7 @@
- ObjectContaining {
+ Object {
+   "attachmentError": Array [],
    "attachments": Array [
      Object {
        "data": Object {},
        "timestamp": 1672592400000,
        "type": 0,
@@ -18,11 +19,38 @@
        },
        "timestamp": 1672592400000,
        "type": 4,
      },
    ],
-   "errors": Array [],
+   "errors": Array [
+     Object {
+       "error.type": Array [],
+       "id": "5c83aaccfffb4a708ae893bad9be3a1c",
+       "issue": "JAVASCRIPT-123E",
+       "issue.id": 3740335939,
+       "level": "Error",
+       "project.name": "javascript",
+       "timestamp": "2023-01-01T17:00:00.000Z",
+       "title": "A Redirect with :orgId param on customer domain",
+     },
+     Object {
+       "error.type": Array [],
+       "id": "5c83aaccfffb4a708ae893bad9be3a1c",
+       "issue": "JAVASCRIPT-123E",
+       "issue.id": 3740335939,
+       "level": "Error",
+       "project.name": "javascript",
+       "timestamp": "2023-01-01T17:00:00.000Z",
+       "title": "A Redirect with :orgId param on customer domain",
+     },
+   ],
+   "feedbackEvents": Array [],
+   "fetchError": undefined,
+   "isError": false,
+   "isPending": false,
+   "onRetry": [Function anonymous],
+   "projectSlug": "project-slug",
    "replayRecord": Object {
      "activity": 0,
      "browser": Object {
        "name": "Other",
        "version": "",
@@ -116,6 +144,7 @@
        "ip": "127.0.0.1",
        "username": "",
      },
      "warning_ids": Array [],
    },
+   "status": "success",
  }

Ignored nodes: comments, script, style
...
    at toStrictEqual (.../replays/hooks/useReplayData.spec.tsx:501:30)
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/node_modules/.pnpm/jsdom@26.1..../jsdom/browser/Window.js:579:19)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@scttcper scttcper merged commit f54a9b0 into master Oct 14, 2025
51 of 53 checks passed
@scttcper scttcper deleted the scttcper/deprecate-test-router branch October 14, 2025 23:45
chromy pushed a commit that referenced this pull request Oct 17, 2025
Try to point people towards the router returned from render, has no use
in the new test environment.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants