fix(ai): Cursor should be reset if env, proj or date changes #101505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilawebdev
changed the title
github-actions
bot
added
the
Scope: Frontend
ArthurKnaus
reviewed
Oct 15, 2025
| : agentRunsRequest.data?.length > 0; | ||
|
|
||
| const resetParamsOnChange = useMemo( | ||
| () => Object.keys(location.query).filter(key => key.toLowerCase().includes('cursor')), |
Member
There was a problem hiding this comment.
I'm not a fan of this matching. Why don't we just use the same cursor name for all tables and reset that one?
Member
Author
There was a problem hiding this comment.
I'm not a fan of this matching. Why don't we just use the same cursor name for all tables and reset that one?
i agree with you but we have many different cursor names, like toolsCursor, tableCursor. to be honest, I am not sure why we did not call them all simple cursor. there isn't an enum for them too. they are many times defined a a plain text.
Member
Author
There was a problem hiding this comment.
Would it make sense to fix the issue now and address improvements afterwards?
Member
There was a problem hiding this comment.
yeah, let's merge this. I will create a ticket
ArthurKnaus
approved these changes
Oct 15, 2025
priscilawebdev
deleted the
priscila/fix/ai/cursor-should-be-reset-on-env-proj-time-change
branch
chromy
pushed a commit
that referenced
this pull request
Oct 17, 2025
**Problem** Users who have paginated a table (with tableCursor in the URL) may encounter an empty page when they change the project, environment, or date. This happens because the pagination cursor points to a page that may not exist in the new context, even though results are available. **Solution** We should follow the behaviour of Discover tables and reset pagination cursors whenever the project, environment, or date changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users who have paginated a table (with tableCursor in the URL) may encounter an empty page when they change the project, environment, or date. This happens because the pagination cursor points to a page that may not exist in the new context, even though results are available.
Solution
We should follow the behaviour of Discover tables and reset pagination cursors whenever the project, environment, or date changes.