Skip to content

feat(agent-spans): Display used tools #101506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

feat(agent-spans): Display used tools #101506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78f3762
feat(agent-spans): Display used tools
ArthurKnaus Oct 15, 2025
14d0ebd
do not run request if ther are no tool names
ArthurKnaus Oct 15, 2025
bab5789
fix types
ArthurKnaus Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion static/app/views/insights/agents/utils/query.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// AI Runs - equivalent to OTEL Invoke Agent span
// https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-agent-spans.md#invoke-agent-span
const AI_RUN_OPS = [
export const AI_RUN_OPS = [
'ai.run.generateText',
'ai.run.generateObject',
'gen_ai.invoke_agent',
Expand Down Expand Up @@ -81,6 +81,10 @@ export const getAIGenerationsFilter = () => {
return `span.op:gen_ai.* !span.op:[${joinValues(NON_GENERATION_OPS)}]`;
};

export const getToolSpansFilter = () => {
return `span.op:"gen_ai.execute_tool"`;
};

export const getAITracesFilter = () => {
return `span.op:gen_ai.*`;
};
1 change: 1 addition & 0 deletions static/app/views/insights/agents/utils/referrers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ export enum Referrer {
MODELS_TABLE = 'api.insights.agent-monitoring.models-table',
TOOLS_TABLE = 'api.insights.agent-monitoring.tools-table',
TRACE_DRAWER = 'api.insights.agent-monitoring.trace-drawer',
TRACE_DRAWER_TOOL_USAGE = 'api.insights.agent-monitoring.trace-drawer-tool-usage',
TRACES_TABLE = 'api.insights.agent-monitoring.traces-table',
TOKEN_USAGE_WIDGET = 'api.insights.agent-monitoring.token-usage-widget',
MODEL_COST_WIDGET = 'api.insights.agent-monitoring.token-cost-widget',
Expand Down
4 changes: 4 additions & 0 deletions .../app/views/performance/newTraceDetails/traceDrawer/details/highlightedAttributes.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ describe('getHighlightedSpanAttributes', () => {

getHighlightedSpanAttributes({
op: 'gen_ai.chat',
spanId: '123',
attributes,
});

Expand Down Expand Up @@ -57,6 +58,7 @@ describe('getHighlightedSpanAttributes', () => {

getHighlightedSpanAttributes({
op: 'gen_ai.chat',
spanId: '123',
attributes,
});

Expand All @@ -70,6 +72,7 @@ describe('getHighlightedSpanAttributes', () => {

getHighlightedSpanAttributes({
op: 'gen_ai.chat',
spanId: '123',
attributes,
});

Expand All @@ -84,6 +87,7 @@ describe('getHighlightedSpanAttributes', () => {

getHighlightedSpanAttributes({
op: 'http.request',
spanId: '123',
attributes,
});

Expand Down
103 changes: 88 additions & 15 deletions static/app/views/performance/newTraceDetails/traceDrawer/details/highlightedAttributes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,26 @@
import styled from '@emotion/styled';
import * as Sentry from '@sentry/react';

import {Tag} from '@sentry/scraps/badge';
import {Flex} from '@sentry/scraps/layout';

import {Tooltip} from 'sentry/components/core/tooltip';
import Count from 'sentry/components/count';
import {StructuredData} from 'sentry/components/structuredEventData';
import {t} from 'sentry/locale';
import {t, tn} from 'sentry/locale';
import {prettifyAttributeName} from 'sentry/views/explore/components/traceItemAttributes/utils';
import type {TraceItemResponseAttribute} from 'sentry/views/explore/hooks/useTraceItemDetails';
import {LLMCosts} from 'sentry/views/insights/agents/components/llmCosts';
import {ModelName} from 'sentry/views/insights/agents/components/modelName';
import {AI_CREATE_AGENT_OPS, getIsAiSpan} from 'sentry/views/insights/agents/utils/query';
import {
AI_CREATE_AGENT_OPS,
AI_RUN_OPS,
getIsAiSpan,
getToolSpansFilter,
} from 'sentry/views/insights/agents/utils/query';
import {Referrer} from 'sentry/views/insights/agents/utils/referrers';
import {useSpans} from 'sentry/views/insights/common/queries/useDiscover';
import {SpanFields} from 'sentry/views/insights/types';

type HighlightedAttribute = {
name: string;
Expand All @@ -26,15 +37,17 @@ function tryParseJson(value: string) {

export function getHighlightedSpanAttributes({
op,
spanId,
attributes = {},
}: {
attributes: Record<string, string> | undefined | TraceItemResponseAttribute[];
op: string | undefined;
spanId: string;
}): HighlightedAttribute[] {
const attributeObject = ensureAttributeObject(attributes);

if (getIsAiSpan({op})) {
return getAISpanAttributes(attributeObject, op);
return getAISpanAttributes({attributes: attributeObject, op, spanId});
}

if (op?.startsWith('mcp.')) {
Expand Down Expand Up @@ -62,10 +75,15 @@ function ensureAttributeObject(
return attributes;
}

function getAISpanAttributes(
attributes: Record<string, string | number | boolean>,
op?: string
) {
function getAISpanAttributes({
op,
spanId,
attributes = {},
}: {
attributes: Record<string, string | number | boolean>;
op: string | undefined;
spanId: string;
}) {
const highlightedAttributes = [];

const agentName = attributes['gen_ai.agent.name'] || attributes['gen_ai.function_id'];
Expand Down Expand Up @@ -142,16 +160,16 @@ function getAISpanAttributes(
}

const availableTools = attributes['gen_ai.request.available_tools'];
if (availableTools && AI_CREATE_AGENT_OPS.includes(op!)) {
const toolsArray = tryParseJson(availableTools?.toString() || '');
if (
toolsArray &&
Array.isArray(toolsArray) &&
toolsArray.length > 0 &&
[...AI_RUN_OPS, ...AI_CREATE_AGENT_OPS].includes(op!)
) {
highlightedAttributes.push({
name: t('Available Tools'),
value: (
<StructuredData
value={tryParseJson(availableTools.toString())}
withAnnotatedText
maxDefaultDepth={0}
/>
),
value: <HighlightedTools availableTools={toolsArray} spanId={spanId} />,
});
}

Expand Down Expand Up @@ -196,6 +214,61 @@ function getMCPAttributes(attributes: Record<string, string | number | boolean>)
return highlightedAttributes;
}

function HighlightedTools({
availableTools,
spanId,
}: {
availableTools: any[];
spanId: string;
}) {
const toolNames = availableTools.map(tool => tool.name).filter(Boolean);
const hasToolNames = toolNames.length > 0;
const toolSpansQuery = useSpans(
{
search: `parent_span:${spanId} has:${SpanFields.GEN_AI_TOOL_NAME} ${getToolSpansFilter()}`,
fields: [SpanFields.GEN_AI_TOOL_NAME],
enabled: hasToolNames,
},
Referrer.TRACE_DRAWER_TOOL_USAGE
);

const usedTools: Map<string, number> = new Map();
toolSpansQuery.data?.forEach(span => {
const toolName = span[SpanFields.GEN_AI_TOOL_NAME];
usedTools.set(toolName, (usedTools.get(toolName) ?? 0) + 1);
});

// Fall back to showing formatted JSON if tool names cannot be parsed
if (!hasToolNames) {
return (
<StructuredData value={availableTools} withAnnotatedText maxDefaultDepth={0} />
);
}

return (
<Flex direction="row" gap="xs" wrap="wrap">
{toolNames.sort().map(tool => {
const usageCount = usedTools.get(tool) ?? 0;
return (
<Tooltip
key={tool}
disabled={toolSpansQuery.isPending}
title={
usageCount === 0
? t('Not used by agent')
: tn('Used %s time', 'Used %s times', usageCount)
}
>
<Tag key={tool} type={usedTools.has(tool) ? 'info' : 'default'}>
{tool}
</Tag>
</Tooltip>
);
})}
</Flex>
);
}

function HighlightedTokenAttributes({
inputTokens,
cachedTokens,
Expand Down
1 change: 1 addition & 0 deletions ...pp/views/performance/newTraceDetails/traceDrawer/details/span/eapSections/description.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ export function SpanDescription({
hideNodeActions={hideNodeActions}
highlightedAttributes={getHighlightedSpanAttributes({
attributes,
spanId: span.event_id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: EAP Span ID Mismatch Causes Tool Data Errors

The getHighlightedSpanAttributes function for EAP spans uses span.event_id as the spanId. This is inconsistent with other span types that use span.span_id. The HighlightedTools component queries for child tool spans using parent_span:${spanId}, which expects the actual span ID. This causes tool usage data for EAP spans to be incorrect or missing.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, for EAP spans the span id is accessed via span.event_id

op: span.op,
})}
/>
Expand Down
1 change: 1 addition & 0 deletions ...c/app/views/performance/newTraceDetails/traceDrawer/details/span/sections/description.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ export function SpanDescription({
hideNodeActions={hideNodeActions}
highlightedAttributes={getHighlightedSpanAttributes({
attributes: span.data,
spanId: span.span_id,
op: span.op,
})}
/>
Expand Down
1 change: 1 addition & 0 deletions ...views/performance/newTraceDetails/traceDrawer/details/transaction/sections/highlights.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ export function TransactionHighlights(props: HighlightProps) {
hideNodeActions={props.hideNodeActions}
highlightedAttributes={getHighlightedSpanAttributes({
attributes: props.event.contexts.trace?.data,
spanId: props.node.value.span_id,
op: props.node.value['transaction.op'],
})}
/>
Expand Down
Loading