Skip to content

fix(inc-1453): Do not crash hard if end_timestamp violates the schema #101512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

fix(inc-1453): Do not crash hard if end_timestamp violates the schema #101512

merged 1 commit into from
Oct 15, 2025

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Oct 15, 2025 •
edited
Loading

@sentry-io Sentry.io
Copy link

sentry-io bot commented Oct 15, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/spans/consumers/process/factory.py

Function Unhandled Issue
process_batch TypeError: '<' not supported between instances of 'NoneType' and 'NoneType' sentry.spans....
Event Count: 660

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 15, 2025
@untitaker untitaker marked this pull request as ready for review October 15, 2025 13:56
@untitaker untitaker requested review from a team as code owners October 15, 2025 13:56
cursor[bot]
cursor bot reviewed Oct 15, 2025
View reviewed changes
@untitaker untitaker enabled auto-merge (squash) October 15, 2025 14:04
@untitaker untitaker merged commit e13449b into master Oct 15, 2025
65 checks passed
@untitaker untitaker deleted the end_timestamp branch October 15, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstory markstory markstory approved these changes

@cursor cursor[bot] cursor[bot] left review comments

@loewenheim loewenheim loewenheim approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@untitaker @markstory @loewenheim