Revert pull request 100515 #101591
Revert pull request 100515 #101591
Conversation
This reverts commit 2d54fa1.
|
Cursor Agent can help with this pull request. Just |
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - added|modified: '.github/file-filters.yml' | ||
| - added|deleted|modified: '**/tsconfig*.json' | ||
| - added|deleted|modified: 'static/**/*.{ts,tsx,js,jsx,mjs}' | ||
| - added|deleted|modified: 'static/**/*.[tj]{s,sx}' |
There was a problem hiding this comment.
Bug: CI Inconsistency with .mjs File Handling
The updated file patterns for testable_modified and typecheckable_rules_changed now use static/**/*.[tj]{s,sx}, which excludes .mjs files. This means changes to .mjs files will no longer trigger relevant CI workflows, and creates an inconsistency with the frontend_all filter that still includes them.
| - added|modified: '.github/file-filters.yml' | ||
| - added|deleted|modified: '**/tsconfig*.json' | ||
| - added|deleted|modified: 'static/**/*.{ts,tsx,js,jsx,mjs}' | ||
| - added|deleted|modified: 'static/**/*.[tj]{s,sx}' |
There was a problem hiding this comment.
Bug: Workflow Filter Fails After Anchor Renaming
The frontend_all filter no longer triggers on changes to .github/workflows/frontend.yml. The sentry_frontend_workflow_file anchor was renamed to sentry_specific_workflow, but its reference in frontend_all was removed instead of being updated, potentially impacting CI workflows.
Reverts PR #100515 ("ci(api): Create a list of valid api urls").
This PR undoes the changes introduced by #100515, which aimed to generate TypeScript API URL definitions from Python.
Key changes reverted:
tools/api_urls_to_typescript.pyscript and its associated pre-commit hook.static/app/utils/api/knownSentryApiUrls.generated.tsandstatic/app/utils/api/knownGetsentryApiUrls.tsfiles.static/app/api/..github/file-filters.ymland.github/workflows/frontend.yml.Conflict Resolution:
A merge conflict in
.github/file-filters.ymlwas resolved by restoring the file to its state prior to PR #100515, as subsequent PR #101568 had introduced fixes related to the original PR's changes.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Slack Thread