feat(native): Introduce CFI Caches #10161
Conversation
| if e.errno != errno.ENOENT: | ||
| raise | ||
| symcache_file.cache_file.save_to(cachefile_path) | ||
| model.cache_file.save_to(cachefile_path) |
There was a problem hiding this comment.
noob question - How do local cache files get removed?
There was a problem hiding this comment.
There's a periodically scheduled job clean_dsymcache that deletes files from the FS cache when they haven't been referenced for 1.5 days or longer. The actual "logic" is defined in this file at the very bottom: clear_old_entries.
jan-auer
force-pushed
the
feat/cfi-caches
branch
from
25e2134 to
af7a040
Compare
|
This is ready for review now. Since it's based off #10052, the first actual commit is 4076e2b. I'll rebase this as soon as we merge the other PR. |
jan-auer
force-pushed
the
feat/cfi-caches
branch
from
854d3c7 to
f42f00a
Compare
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Looks good to me, but I have very little context on this section of the application.
| def broken_make_symcache(self): | ||
| @classmethod | ||
| def broken_make_symcache(cls, obj): | ||
| raise SymbolicError('shit on fire') |
| cficaches = ProjectDebugFile.difcache.get_cficaches(self.project, [debug_id]) | ||
| assert debug_id in cficaches | ||
|
|
||
| def test_update_cficache(self): |
There was a problem hiding this comment.
Should there be a test for updating a cache file when the cache file has already been created by 'another' process?
There was a problem hiding this comment.
Yes, there should. I'm just not sure how to do this (as this can only happen for concurrent processes) and I don't want to mock the entire world. There will be a test for this soon, but for now please just believe me that this works :)
Introduces a new model
ProjectCfiCacheFileand generalizes cache generation over symcaches and CFI caches.Based on #10052
Requires getsentry/symbolic#93