chore(dashboards): Centralize search bar data hook invocation #101622

Ahmed-Labs · 2025-10-16T19:01:10Z

Motivation:

I previously looped through datasets and called the corresponding searchbar data hook to build a map on the fly. This is bad practice because hook calls should be explicit and unconditional.
When I create numeric & date filter components, I need to use the SearchSyntax parser instead of MutableSearch. SearchSyntax requires providing all filter keys of a dataset. So, instead of repeating filter key retrieval across components, it is more organized and performant to centralize it in a single hook.

Changes:

Creates central hook for all dataset search bar data that explicitly invokes search bar data hooks for all datasets.
Replaces looped hook calls in the addFilter component with the centralized data hook.

codecov · 2025-10-16T19:06:59Z

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
12183	3	12180	10

View the top 3 failed test(s) by shortest run time

AddFilter calls onAddFilter with expected global filter object

Stack Traces | 0.164s run time

TypeError: getSearchBarData is not a function
    at getSearchBarData (.../dashboards/globalFilter/addFilter.tsx:62:24)
    at Object.react_stack_bottom_frame (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:25904:20)
    at renderWithHooks (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:7662:22)
    at updateFunctionComponent (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:10166:19)
    at beginWork (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:11778:18)
    at runWithFiberInDEV (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:874:13)
    at performUnitOfWork (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:17641:22)
    at workLoopSync (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:17469:41)
    at renderRootSync (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:17450:11)
    at performWorkOnRoot (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:16583:35)
    at performSyncWorkOnRoot (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18972:7)
    at flushSyncWorkAcrossRoots_impl (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18814:21)
    at processRootScheduleInMicrotask (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18853:9)
    at .../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18982:11
    at flushActQueue (.../sentry/node_modules/.pnpm/react@19.2..../react/cjs/react.development.js:590:34)
    at process.env.NODE_ENV.exports.act (.../sentry/node_modules/.pnpm/react@19.2..../react/cjs/react.development.js:884:10)
    at .../sentry/node_modules/.pnpm/@testing-library+react@16.2.0_@testing-library+dom@10.4.0_@types+react-dom@19.2.0_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/act-compat.js:47:25
    at Object.eventWrapper (.../sentry/node_modules/.pnpm/@testing-library+react@16.2.0_@testing-library+dom@10.4.0_@types+react-dom@19.2.0_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/pure.js:107:28)
    at Object.wrapEvent (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/event/wrapEvent.js:6:28)
    at Object.dispatchEvent (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/event/dispatchEvent.js:45:22)
    at Object.dispatchUIEvent (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/event/dispatchEvent.js:22:26)
    at Mouse.up (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../system/pointer/mouse.js:100:30)
    at PointerHost.release (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../system/pointer/index.js:87:24)
    at pointerAction (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/pointer/index.js:54:47)
    at Object.pointer (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/pointer/index.js:27:9)
    at Object.asyncWrapper (.../sentry/node_modules/.pnpm/@testing-library+react@16.2.0_@testing-library+dom@10.4.0_@types+react-dom@19.2.0_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/pure.js:88:22)
    at Object.<anonymous> (.../dashboards/globalFilter/addFilter.spec.tsx:126:5)

AddFilter retrieves filter keys for each dataset

Stack Traces | 0.199s run time

TypeError: getSearchBarData is not a function
    at getSearchBarData (.../dashboards/globalFilter/addFilter.tsx:62:24)
    at Object.react_stack_bottom_frame (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:25904:20)
    at renderWithHooks (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:7662:22)
    at updateFunctionComponent (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:10166:19)
    at beginWork (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:11778:18)
    at runWithFiberInDEV (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:874:13)
    at performUnitOfWork (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:17641:22)
    at workLoopSync (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:17469:41)
    at renderRootSync (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:17450:11)
    at performWorkOnRoot (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:16583:35)
    at performSyncWorkOnRoot (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18972:7)
    at flushSyncWorkAcrossRoots_impl (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18814:21)
    at processRootScheduleInMicrotask (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18853:9)
    at .../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18982:11
    at flushActQueue (.../sentry/node_modules/.pnpm/react@19.2..../react/cjs/react.development.js:590:34)
    at process.env.NODE_ENV.exports.act (.../sentry/node_modules/.pnpm/react@19.2..../react/cjs/react.development.js:884:10)
    at .../sentry/node_modules/.pnpm/@testing-library+react@16.2.0_@testing-library+dom@10.4.0_@types+react-dom@19.2.0_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/act-compat.js:47:25
    at Object.eventWrapper (.../sentry/node_modules/.pnpm/@testing-library+react@16.2.0_@testing-library+dom@10.4.0_@types+react-dom@19.2.0_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/pure.js:107:28)
    at Object.wrapEvent (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/event/wrapEvent.js:6:28)
    at Object.dispatchEvent (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/event/dispatchEvent.js:45:22)
    at Object.dispatchUIEvent (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/event/dispatchEvent.js:22:26)
    at Mouse.up (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../system/pointer/mouse.js:100:30)
    at PointerHost.release (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../system/pointer/index.js:87:24)
    at pointerAction (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/pointer/index.js:54:47)
    at Object.pointer (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/pointer/index.js:27:9)
    at Object.asyncWrapper (.../sentry/node_modules/.pnpm/@testing-library+react@16.2.0_@testing-library+dom@10.4.0_@types+react-dom@19.2.0_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/pure.js:88:22)
    at Object.<anonymous> (.../dashboards/globalFilter/addFilter.spec.tsx:80:7)

AddFilter does not render unsupported filter keys

Stack Traces | 0.228s run time

TypeError: getSearchBarData is not a function
    at getSearchBarData (.../dashboards/globalFilter/addFilter.tsx:62:24)
    at Object.react_stack_bottom_frame (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:25904:20)
    at renderWithHooks (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:7662:22)
    at updateFunctionComponent (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:10166:19)
    at beginWork (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:11778:18)
    at runWithFiberInDEV (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:874:13)
    at performUnitOfWork (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:17641:22)
    at workLoopSync (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:17469:41)
    at renderRootSync (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:17450:11)
    at performWorkOnRoot (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:16583:35)
    at performSyncWorkOnRoot (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18972:7)
    at flushSyncWorkAcrossRoots_impl (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18814:21)
    at processRootScheduleInMicrotask (.../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18853:9)
    at .../sentry/node_modules/.pnpm/react-dom@19.2.0_react@19.2..../react-dom/cjs/react-dom-client.development.js:18982:11
    at flushActQueue (.../sentry/node_modules/.pnpm/react@19.2..../react/cjs/react.development.js:590:34)
    at process.env.NODE_ENV.exports.act (.../sentry/node_modules/.pnpm/react@19.2..../react/cjs/react.development.js:884:10)
    at .../sentry/node_modules/.pnpm/@testing-library+react@16.2.0_@testing-library+dom@10.4.0_@types+react-dom@19.2.0_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/act-compat.js:47:25
    at Object.eventWrapper (.../sentry/node_modules/.pnpm/@testing-library+react@16.2.0_@testing-library+dom@10.4.0_@types+react-dom@19.2.0_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/pure.js:107:28)
    at Object.wrapEvent (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/event/wrapEvent.js:6:28)
    at Object.dispatchEvent (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/event/dispatchEvent.js:45:22)
    at Object.dispatchUIEvent (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/event/dispatchEvent.js:22:26)
    at Mouse.up (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../system/pointer/mouse.js:100:30)
    at PointerHost.release (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../system/pointer/index.js:87:24)
    at pointerAction (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/pointer/index.js:54:47)
    at Object.pointer (.../sentry/node_modules/.pnpm/@testing-library+user-event@14.6.1_@testing-library+dom@10.4.0/node_modules/@.../cjs/pointer/index.js:27:9)
    at Object.asyncWrapper (.../sentry/node_modules/.pnpm/@testing-library+react@16.2.0_@testing-library+dom@10.4.0_@types+react-dom@19.2.0_@type_011f94990cdc27509fa142ae9e3c3bf5/node_modules/@.../react/dist/pure.js:88:22)
    at Object.<anonymous> (.../dashboards/globalFilter/addFilter.spec.tsx:102:5)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

…dataset

…ion in other component

…ng called by the search bar data hook in the filtersBar

sentry · 2025-10-20T16:41:41Z

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

‼️ TypeError: Cannot read properties of undefined (re... in ci:pull_request

create central hook for all dataset search bar data

9a22945

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 16, 2025

vercel bot deployed to Preview October 16, 2025 19:41 View deployment

Ahmed-Labs added 5 commits October 16, 2025 15:59

use centralized searchbar data hook to retrieve filter keys for each …

84afeaf

…dataset

change dataset label argument back to WidgetType to avoid type assert…

cf4385c

…ion in other component

update addFilter tests to use new centralized search bar data hook

f42f850

remove unused import

486bb35

use centralized search bar data hook in the filter selector component

4e0741f

Ahmed-Labs force-pushed the ahmedmo/chore/centralize-searchbar-data-hook-invocation branch from 690eca3 to 4e0741f Compare October 16, 2025 20:00

vercel bot deployed to Preview October 16, 2025 20:02 View deployment

rename dataset search bar data hook file

286186e

vercel bot deployed to Preview October 16, 2025 20:18 View deployment

update global filter selector tests to use mock search bar data

7b74c41

Ahmed-Labs force-pushed the ahmedmo/chore/centralize-searchbar-data-hook-invocation branch from 94042bf to 7b74c41 Compare October 16, 2025 20:19

vercel bot deployed to Preview October 16, 2025 20:21 View deployment

add mock response for cusom measurements endpoint since it is now bei…

90c6a75

…ng called by the search bar data hook in the filtersBar

vercel bot deployed to Preview October 16, 2025 20:27 View deployment

Ahmed-Labs marked this pull request as ready for review October 16, 2025 21:08

Ahmed-Labs requested a review from a team October 16, 2025 21:08

This comment was marked as outdated.

Sign in to view

refactor centralized search bar data hook

bd70ebd

vercel bot deployed to Preview October 17, 2025 18:52 View deployment

fix breaking test after search bar data hook change

d7cc771

vercel bot deployed to Preview October 17, 2025 19:06 View deployment

nikkikapadia approved these changes Oct 20, 2025

View reviewed changes

Ahmed-Labs merged commit 271ebe4 into master Oct 20, 2025
47 checks passed

Ahmed-Labs deleted the ahmedmo/chore/centralize-searchbar-data-hook-invocation branch October 20, 2025 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(dashboards): Centralize search bar data hook invocation #101622

chore(dashboards): Centralize search bar data hook invocation #101622

Uh oh!

Ahmed-Labs commented Oct 16, 2025

Uh oh!

codecov bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

sentry bot commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

chore(dashboards): Centralize search bar data hook invocation #101622

chore(dashboards): Centralize search bar data hook invocation #101622

Uh oh!

Conversation

Ahmed-Labs commented Oct 16, 2025

Uh oh!

codecov bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 3 Tests Failed:

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

sentry bot commented Oct 20, 2025

Issues attributed to commits in this pull request

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 16, 2025 •

edited

Loading