Skip to content

Conversation

@Ahmed-Labs
Copy link
Member

@Ahmed-Labs Ahmed-Labs commented Oct 22, 2025

Global filter fixes:

  • filterSelector:
    • Display saved global filter value selections even if not present in fetched values
    • Add page filters as a debounce parameter to fetch new values upon page filter changes
  • addFilter:
    • Only display string and boolean filter keys
    • When disabling filter keys that already exist global filters, check that the dataset matches as well

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
12221 2 12219 10
View the top 2 failed test(s) by shortest run time
AddFilter retrieves filter keys for each dataset
Stack Traces | 0.229s run time
TestingLibraryElementError: Unable to find an element with the text: browser. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByText (.../dashboards/globalFilter/addFilter.spec.tsx:72:21)
AddFilter calls onAddFilter with expected global filter object
Stack Traces | 0.27s run time
TestingLibraryElementError: Unable to find an element with the text: browser. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByText (.../dashboards/globalFilter/addFilter.spec.tsx:117:34)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Ahmed-Labs Ahmed-Labs force-pushed the ahmedmo/fix/dashboard-global-filters-display-saved-selections branch from ef78861 to 82c7ea1 Compare October 24, 2025 15:28
@Ahmed-Labs Ahmed-Labs merged commit 02d0649 into master Oct 24, 2025
47 checks passed
@Ahmed-Labs Ahmed-Labs deleted the ahmedmo/fix/dashboard-global-filters-display-saved-selections branch October 24, 2025 16:12
priscilawebdev pushed a commit that referenced this pull request Oct 28, 2025
…101930)

Global filter fixes:
- filterSelector:
- Display saved global filter value selections even if not present in
fetched values
- Add page filters as a debounce parameter to fetch new values upon page
filter changes
- addFilter: 
- Only display string and boolean filter keys
- When disabling filter keys that already exist global filters, check
that the dataset matches as well
shashjar pushed a commit that referenced this pull request Nov 4, 2025
…101930)

Global filter fixes:
- filterSelector:
- Display saved global filter value selections even if not present in
fetched values
- Add page filters as a debounce parameter to fetch new values upon page
filter changes
- addFilter: 
- Only display string and boolean filter keys
- When disabling filter keys that already exist global filters, check
that the dataset matches as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants