feat(tracemetrics): Sync chart cursors #101958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
k-fish
approved these changes
Oct 22, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| metricQueries.length, | ||
| !timeseriesResult.isPending, | ||
| METRICS_CHART_GROUP | ||
| ); |
Contributor
There was a problem hiding this comment.
Bug: Hook Misuse Causes Chart Sync Issues
The useSynchronizeCharts hook is called per MetricsGraph component, rather than once for the chart group. This means multiple calls for the same group, each with its own loading state, which can cause inconsistent synchronization or race conditions.
Member
Author
|
Going to keep this open for a sec, there's an issue with the chart after adding synced cursors (when the panel slider moves, the charts don't resize, the overflow is just hidden) |
…try/sentry into nar/feat/tracemetrics-sync-charts
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
Synchronizes the chart cursors on hover
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Synchronizes the chart cursors on hover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronizes the chart cursors on hover.
Closes LOGS-467