feat(issues): Include empty tags in group tagkey values endpoints #102048

scttcper · 2025-10-23T22:00:19Z

Add support for including empty tag values in the group tagkey values endpoints when the organizations:issue-tags-include-empty-values feature flag is enabled.

Currently will display an empty string and the count and will need to follow up with frontend fixes.

part of https://linear.app/getsentry/issue/RTC-1181/

Add support for including empty tag values in the group tagkey values endpoints when the organizations:issue-tags-include-empty-values feature flag is enabled. Endpoints affected: - api/0/issues/{id}/tags/{key}/values/ - api/0/issues/{id}/tags/{key}/ Changes: - Add include_empty_values parameter to get_group_tag_key, get_group_tag_value_iter, get_group_tag_value_paginator, get_group_tag_value_count, and get_top_group_tag_values methods - Update __get_tag_key_and_top_values to conditionally exclude empty values - Update group_tagkey_values and group_tagkey_details endpoints to check feature flag - Add feature flag organizations:issue-tags-include-empty-values - Add tests for empty tag inclusion behavior

linear · 2025-10-23T22:00:23Z

RTC-1181 The Issue Details tag list value percentages are misleading

cursor · 2025-10-23T22:07:08Z

src/sentry/tagstore/snuba/backend.py

-            self.key_column: [key],
        }
+        if not include_empty_values:
+            filters[self.key_column] = [key]


Bug: Tag Key Filter Ignored When Including Empty Values

When include_empty_values is True in get_group_tag_value_iter, the query incorrectly omits the filter for the specific tag key. This results in the method returning values for all tag keys in the group, instead of only the requested one. The include_empty_values parameter was intended to control filtering of empty values, not the tag key itself.

Bot comment seems reasonable — can you explain why you're now omitting the key filter?

added a comment

seer-by-sentry · 2025-10-23T22:08:01Z

src/sentry/tagstore/snuba/backend.py

+        if not include_empty_values:
+            filters[self.key_column] = [key]
        dataset, filters = self.apply_group_filters(group, filters)


Bug: When include_empty_values is true in get_group_tag_value_iter, the filter for the specific tag key is omitted, causing the query to return values for all tags.
_{Severity: CRITICAL | Confidence: 0.95}

🔍 Detailed Analysis

In the `get_group_tag_value_iter` method, when `include_empty_values` is `True`, a filter to restrict the query to the specified tag `key` is not applied. The line `filters[self.key_column] = [key]` is only executed when `include_empty_values` is `False`. Without this filter, the Snuba query will fetch values from all tag keys for the given group, not just the one requested. This leads to incorrect data being returned to the client, including wrong tag values, inaccurate counts, and faulty pagination, as the aggregations and limits are applied to a much larger, incorrect dataset.

💡 Suggested Fix

The filter filters[self.key_column] = [key] should be applied regardless of the value of include_empty_values. Move this line of code so that it is executed before the if not include_empty_values: block, ensuring the query is always correctly filtered by the requested tag key.

🤖 Prompt for AI Agent

Fix this bug. In src/sentry/tagstore/snuba/backend.py at lines 1408-1410: In the `get_group_tag_value_iter` method, when `include_empty_values` is `True`, a filter to restrict the query to the specified tag `key` is not applied. The line `filters[self.key_column] = [key]` is only executed when `include_empty_values` is `False`. Without this filter, the Snuba query will fetch values from all tag keys for the given group, not just the one requested. This leads to incorrect data being returned to the client, including wrong tag values, inaccurate counts, and faulty pagination, as the aggregations and limits are applied to a much larger, incorrect dataset.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

codecov · 2025-10-23T22:44:35Z

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/tagstore/snuba/backend.py	90.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #102048      +/-   ##
===========================================
+ Coverage   75.54%    80.90%   +5.36%     
===========================================
  Files        8819      8822       +3     
  Lines      389819    389901      +82     
  Branches    24799     24799              
===========================================
+ Hits       294475    315445   +20970     
+ Misses      94982     74094   -20888     
  Partials      362       362

thetruecpaul · 2025-10-28T15:21:45Z

src/sentry/features/temporary.py

    # Whether to allow issue only search on the issue list
    manager.add("organizations:issue-search-allow-postgres-only-search", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
+    # Include empty tag count in issue tag totals/values
+    manager.add("organizations:issue-tags-include-empty-values", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)


This is in temporary.py — just confirming that we plan to roll this out to all orgs eventually?

yes! asap. Felt dangerous enough to put behind a flag and it needs frontend changes

src/sentry/tagstore/snuba/backend.py

thetruecpaul · 2025-10-28T15:31:25Z

src/sentry/tagstore/snuba/backend.py

-            self.key_column: [key],
        }
+        if not include_empty_values:
+            filters[self.key_column] = [key]


Bot comment seems reasonable — can you explain why you're now omitting the key filter?

…-values

thetruecpaul

LGTM

…02048) Add support for including empty tag values in the group tagkey values endpoints when the organizations:issue-tags-include-empty-values feature flag is enabled. Currently will display an empty string and the count and will need to follow up with frontend fixes. <img width="924" height="341" alt="image" src="https://github.com/user-attachments/assets/abe4744e-ebbd-4340-bdaa-fe78f9af9957" /> part of https://linear.app/getsentry/issue/RTC-1181/

remove cast

e2dc0d2

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2025

vercel bot deployed to Preview October 23, 2025 22:02 View deployment

scttcper marked this pull request as ready for review October 23, 2025 22:06

scttcper requested review from a team as code owners October 23, 2025 22:06

scttcper requested a review from wedamija October 23, 2025 22:06

cursor bot reviewed Oct 23, 2025

View reviewed changes

seer-by-sentry bot reviewed Oct 23, 2025

View reviewed changes

revert limit change

656d2e5

vercel bot deployed to Preview October 23, 2025 22:12 View deployment

scttcper added 2 commits October 23, 2025 15:20

fix test mock

fe0c17d

=false

319b4cc

vercel bot deployed to Preview October 23, 2025 22:23 View deployment

=False

f9c591d

vercel bot deployed to Preview October 23, 2025 22:33 View deployment

thetruecpaul reviewed Oct 28, 2025

View reviewed changes

remove safe limit

5e16711

vercel bot deployed to Preview October 28, 2025 17:46 View deployment

add comment on why we would remove the filter, remove conditions

5118cb3

vercel bot deployed to Preview October 28, 2025 18:10 View deployment

scttcper requested a review from thetruecpaul October 28, 2025 21:55

Merge branch 'master' into scttcper/issue-tagkey-values-include-empty…

f6b0c0b

…-values

vercel bot deployed to Preview October 29, 2025 20:52 View deployment

Merge branch 'master' into scttcper/issue-tagkey-values-include-empty…

83d8d04

…-values

vercel bot deployed to Preview October 29, 2025 22:24 View deployment

Merge branch 'master' into scttcper/issue-tagkey-values-include-empty…

c4f8cf4

…-values

vercel bot deployed to Preview October 29, 2025 22:46 View deployment

scttcper added 2 commits October 30, 2025 10:52

add request.user to flag check

ca02c7d

Merge branch 'master' into scttcper/issue-tagkey-values-include-empty…

59ce4ff

…-values

vercel bot deployed to Preview October 30, 2025 17:55 View deployment

thetruecpaul approved these changes Oct 30, 2025

View reviewed changes

scttcper merged commit 73bc978 into master Oct 30, 2025
68 checks passed

scttcper deleted the scttcper/issue-tagkey-values-include-empty-values branch October 30, 2025 18:32

github-actions bot locked and limited conversation to collaborators Nov 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(issues): Include empty tags in group tagkey values endpoints #102048

feat(issues): Include empty tags in group tagkey values endpoints #102048

Uh oh!

scttcper commented Oct 23, 2025

Uh oh!

linear bot commented Oct 23, 2025

Uh oh!

cursor bot Oct 23, 2025

Uh oh!

thetruecpaul Oct 28, 2025

Uh oh!

scttcper Oct 28, 2025

Uh oh!

seer-by-sentry bot Oct 23, 2025

Uh oh!

codecov bot commented Oct 23, 2025 •

edited

Loading

Uh oh!

thetruecpaul Oct 28, 2025

Uh oh!

scttcper Oct 28, 2025

Uh oh!

Uh oh!

thetruecpaul Oct 28, 2025

Uh oh!

thetruecpaul left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(issues): Include empty tags in group tagkey values endpoints #102048

feat(issues): Include empty tags in group tagkey values endpoints #102048

Uh oh!

Conversation

scttcper commented Oct 23, 2025

Uh oh!

linear bot commented Oct 23, 2025

Uh oh!

cursor bot Oct 23, 2025

Choose a reason for hiding this comment

Bug: Tag Key Filter Ignored When Including Empty Values

Uh oh!

thetruecpaul Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

scttcper Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

seer-by-sentry bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thetruecpaul Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

scttcper Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thetruecpaul Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

thetruecpaul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 23, 2025 •

edited

Loading