Skip to content

feat(select): Introduce 'menuPlacement=auto' by default for all selects #102067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2025
Merged

feat(select): Introduce 'menuPlacement=auto' by default for all selects #102067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/components/core/select/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ function SelectPicker<OptionType extends OptionTypeBase>({
Component = ReactSelect;
}

return <Component ref={ref as any} {...props} />;
return <Component ref={ref as any} {...props} menuPlacement="auto" />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Default Prop Overriding User Input

The menuPlacement="auto" prop is placed after {...props}, causing it to override any menuPlacement value passed in props instead of serving as a default. This prevents users from customizing the menu placement.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bingo. that is what we want!

}

// XXX (tkdodo): this type assertion is a leftover from when we had forwardRef
Expand Down
Loading