fix(cleanup): Fix flaky test #102077
Merged
fix(cleanup): Fix flaky test #102077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to `prepare_deletes_by_project` are not ordered, thus, adjusting the tests. Fixes [SENTRY-TESTS-19TC](https://sentry.sentry.io/issues/6971597318/).
JoshFerge
approved these changes
Oct 24, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| assert query is not None | ||
| project_ids = list(query.values_list("id", flat=True)) | ||
| assert project_ids == [project1.id, project2.id] | ||
| assert sorted(project_ids) == [project1.id, project2.id] |
Contributor
There was a problem hiding this comment.
Bug: Test Assertions Fail Due to Unsorted Project IDs
The prepare_deletes_by_project tests sort the query results but not the expected project ID lists in the assertions. This makes the tests brittle, as they implicitly rely on project IDs being assigned in ascending order, which could lead to unexpected failures.
priscilawebdev
pushed a commit
that referenced
this pull request
Oct 28, 2025
Calls to `prepare_deletes_by_project` are not ordered, thus, adjusting the tests. Fixes [SENTRY-TESTS-19TC](https://sentry.sentry.io/issues/6971597318/).
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
Calls to `prepare_deletes_by_project` are not ordered, thus, adjusting the tests. Fixes [SENTRY-TESTS-19TC](https://sentry.sentry.io/issues/6971597318/).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
prepare_deletes_by_projectare not ordered, thus, adjusting the tests.Fixes SENTRY-TESTS-19TC.