ref(uptime): move uptime helper functions to utility file #102105
Merged
+82
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
shashjar
approved these changes
Oct 24, 2025
klochek
force-pushed
the
christopherklochek/uptime_util
branch
from
4e6181f to
a164b38
Compare
priscilawebdev
pushed a commit
that referenced
this pull request
Oct 28, 2025
Sorry. But these are functions that have moved around a couple of times due to circular dependency issues, so let's just push them into their own file. I also looked at most of the major files in uptime to see if there were any other obvious candidates to be moved here, but from what I can tell, it's relatively tidy. (I also put back the get_cluster() call I had to inline, in a preceding PR.)
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
Sorry. But these are functions that have moved around a couple of times due to circular dependency issues, so let's just push them into their own file. I also looked at most of the major files in uptime to see if there were any other obvious candidates to be moved here, but from what I can tell, it's relatively tidy. (I also put back the get_cluster() call I had to inline, in a preceding PR.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry. But these are functions that have moved around a couple of times due to circular dependency issues, so let's just push them into their own file. I also looked at most of the major files in uptime to see if there were any other obvious candidates to be moved here, but from what I can tell, it's relatively tidy.
(I also put back the get_cluster() call I had to inline, in a preceding PR.)