ref(grouping): Small refactors to prep for new config #102339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102339 +/- ##
===========================================
- Coverage 80.90% 80.89% -0.01%
===========================================
Files 8821 8821
Lines 389819 389818 -1
Branches 24795 24795
===========================================
- Hits 315365 315357 -8
- Misses 74092 74099 +7
Partials 362 362 |
lobsterkatie
force-pushed
the
kmclb-pre-new-config-refactors
branch
from
524be5f to
d3b796f
Compare
lobsterkatie
force-pushed
the
kmclb-pre-new-config-refactors
branch
from
d3b796f to
d6afe91
Compare
shashjar
approved these changes
Oct 30, 2025
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
This includes three small refactors to grouping code, pulled from upcoming PRs to keep them scoped to their actual purpose. - Simplify adding values to exception grouping components. - Pull useful values into variables in grouping config upgrade function. - In stacktrace strategy, use `has_url_origin` helper over `is_url` for consistency with the rest of the grouping code.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
This includes three small refactors to grouping code, pulled from upcoming PRs to keep them scoped to their actual purpose. - Simplify adding values to exception grouping components. - Pull useful values into variables in grouping config upgrade function. - In stacktrace strategy, use `has_url_origin` helper over `is_url` for consistency with the rest of the grouping code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes three small refactors to grouping code, pulled from upcoming PRs to keep them scoped to their actual purpose.
has_url_originhelper overis_urlfor consistency with the rest of the grouping code.