feat(eco): link integration resolve activities to GroupResolution for regression detection #102340
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… regression detection Integration webhooks that resolve issues in releases were creating SET_RESOLVED_IN_RELEASE activities without linking them to their GroupResolution via the ident field. This prevented event_manager from finding the resolution activity during regression detection, causing follows_semver and resolved_in_version fields to be missing from regression activities. Now we retroactively link the activity after creating the GroupResolution so regressions can properly display semver comparison context.
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102340 +/- ##
========================================
Coverage 80.95% 80.95%
========================================
Files 8797 8797
Lines 389840 389810 -30
Branches 24800 24800
========================================
- Hits 315607 315583 -24
+ Misses 73859 73853 -6
Partials 374 374 |
Use activity_type.value in the ident-linking query to avoid passing the Enum to the ORM filter. This fixes tests failing with TypeError when filtering by Activity.type.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| .first() | ||
| ) | ||
| if latest_resolution_activity and not latest_resolution_activity.ident: | ||
| latest_resolution_activity.update(ident=resolution.id) |
Contributor
There was a problem hiding this comment.
Bug: Activity Linking Fails on Updated Resolutions
The if created: condition incorrectly restricts linking a new Activity to its GroupResolution only when the resolution is newly created. When an existing GroupResolution is updated, the Activity.ident field remains unset, which breaks regression detection functionality.
Member
Author
There was a problem hiding this comment.
i think that should be okay
armenzg
approved these changes
Oct 30, 2025
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
… regression detection (#102340) Integration webhooks that resolve issues in releases were creating SET_RESOLVED_IN_RELEASE activities without linking them to their GroupResolution via the ident field. This prevented event_manager from finding the resolution activity during regression detection, causing follows_semver and resolved_in_version fields to be missing from regression activities. fixes #102234
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
… regression detection (#102340) Integration webhooks that resolve issues in releases were creating SET_RESOLVED_IN_RELEASE activities without linking them to their GroupResolution via the ident field. This prevented event_manager from finding the resolution activity during regression detection, causing follows_semver and resolved_in_version fields to be missing from regression activities. fixes #102234
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration webhooks that resolve issues in releases were creating SET_RESOLVED_IN_RELEASE activities without linking them to their GroupResolution via the ident field. This prevented event_manager from finding the resolution activity during regression detection, causing follows_semver and resolved_in_version fields to be missing from regression activities.
fixes #102234