fix(eco): Allow superusers to view integration configuration #102353
Conversation
Currently blocks the link and redirects you away. Let me see it.
| integrationSlug={integrationSlug} | ||
| description={description} | ||
| alerts={alerts} | ||
| <SentryDocumentTitle title={integrationName}> |
There was a problem hiding this comment.
all whitespace changes except for this
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| const superuser = isActiveSuperuser(); | ||
| const canConfigure = | ||
| (hasAccess || superuser) && this.integrationStatus === 'active'; | ||
| const disableAction = !(hasAccess && this.integrationStatus === 'active'); |
There was a problem hiding this comment.
Bug: Superusers without org:integrations permission cannot upgrade integrations because disableAction incorrectly disables the "Update Now" button.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
When a superuser without org:integrations permission attempts to upgrade an integration, the "Update Now" button is disabled. This occurs because the disableAction variable at line 121 does not account for superuser status, unlike the canConfigure variable used for the "Configure" button. This leads to an inconsistent user experience where a superuser can configure an integration but cannot update it.
💡 Suggested Fix
Update the disableAction variable at line 121 to include superuser status, similar to how canConfigure is defined, to allow superusers to upgrade integrations.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location:
static/app/views/settings/organizationIntegrations/installedIntegration.tsx#L121
Potential issue: When a superuser without `org:integrations` permission attempts to
upgrade an integration, the "Update Now" button is disabled. This occurs because the
`disableAction` variable at line 121 does not account for superuser status, unlike the
`canConfigure` variable used for the "Configure" button. This leads to an inconsistent
user experience where a superuser can configure an integration but cannot update it.
Did we get this right? 👍 / 👎 to inform future reviews.
displays integration activity information if the activity came from an activity
This reverts commit fcb2978.
Currently blocks the link and redirects you away. Let me see it. Adds missing document title on integration details page. <img width="694" height="389" alt="image" src="https://github.com/user-attachments/assets/9930d1c9-a2ea-454c-badf-b45ec89f89cf" />
Currently blocks the link and redirects you away. Let me see it. Adds missing document title on integration details page. <img width="694" height="389" alt="image" src="https://github.com/user-attachments/assets/9930d1c9-a2ea-454c-badf-b45ec89f89cf" />
Currently blocks the link and redirects you away. Let me see it. Adds missing document title on integration details page.