ref(billing): Clean up hardcoded on-demand terms #102408

isabellaenriquez · 2025-10-30T16:22:18Z

Mainly just cleaning up where we display the term to users everywhere; some comments and variable names updated but we'll probably need to do the rest (if ever) when we update on the backend too.

linear · 2025-10-30T16:22:21Z

BIL-1672 Don't hardcode any budget terms

codecov · 2025-10-30T16:27:57Z

❌ 14 Tests Failed:

Tests completed	Failed	Passed	Skipped
12288	14	12274	10

View the top 3 failed test(s) by shortest run time

PendingChanges renders on-demand budgets

Stack Traces | 0.035s run time

Error: expect(element).toHaveTextContent()

Expected element to have text content:
  On-demand budget — shared on-demand budget of $100 → per-category on-demand budget (errors at $3, transactions at $2, and attachments at $1)
Received:
  This account has pending changes to the subscriptionThe following changes will take effect on Mar 16, 2022:Plan changes — Developer → Team (Enterprise)Contract period — monthly → annualBilling period — monthly → annualReserved errors — 5,000 → 0 errorsReserved transactions — 10,000 → 0 transactionsReserved replays — 50 → 0 replaysReserved attachments — 1 GB → 0 GB attachmentsReserved cron monitors — 1 → 0 monitorSeatsReserved uptime monitors — 1 → 0 uptimeReserved cost-per-event for seerAutofix — $1.00000000 → None Reserved cost-per-event for seerScanner — $0.01000000 → None Reserved budgets — $0.00 for seer budget → NoneThe following changes will take effect on Feb 16, 2022:On-Demand Budget — shared on-demand budget of $100 → per-category on-demand budget (errors at $3, transactions at $2, and attachments at $1)
    at Object.toHaveTextContent (.../components/customers/pendingChanges.spec.tsx:191:23)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

PendingChanges combines regular and on-demand changes

Stack Traces | 0.041s run time

Error: expect(element).toHaveTextContent()

Expected element to have text content:
  On-demand budget — shared on-demand budget of $100 → per-category on-demand budget (errors at $3, transactions at $2, and attachments at $1)
Received:
  This account has pending changes to the subscriptionThe following changes will take effect on Mar 16, 2022:Plan changes — Developer → Team (Enterprise)Contract period — monthly → annualBilling period — monthly → annualReserved errors — 5,000 → 0 errorsReserved transactions — 10,000 → 0 transactionsReserved replays — 50 → 0 replaysReserved attachments — 1 GB → 0 GB attachmentsReserved cron monitors — 1 → 0 monitorSeatsReserved uptime monitors — 1 → 0 uptimeReserved cost-per-event for seerAutofix — $1.00000000 → None Reserved cost-per-event for seerScanner — $0.01000000 → None Reserved budgets — $0.00 for seer budget → NoneOn-Demand Budget — shared on-demand budget of $100 → per-category on-demand budget (errors at $3, transactions at $2, and attachments at $1)
    at Object.toHaveTextContent (.../components/customers/pendingChanges.spec.tsx:236:23)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

PendingChanges renders pending changes with all categories

Stack Traces | 0.063s run time

Error: expect(element).toHaveTextContent()

Expected element to have text content:
  On-demand maximum — $0.00 → $500.00
Received:
  This account has pending changes to the subscriptionThe following changes will take effect on Oct 9, 2024:Plan changes — Developer → Team (Enterprise)Contract period — monthly → annualBilling period — monthly → annualReserved errors — 5,000 → 15,000,000 errorsReserved transactions — 10,000 → 0 transactionsReserved replays — 50 → 0 replaysReserved attachments — 1 GB → 25 GB attachmentsReserved cron monitors — 1 → 0 monitorSeatsReserved uptime monitors — 1 → 0 uptimeReserved spans — 0 → 20,000,000 spansCustom price (ACV) — $0.00 → $50,000.00Custom price for errors — $0.00 → $20,000.00 Custom price for attachments — $0.00 → $500.00 Custom price for spans — $0.00 → $2,000.00 Custom price for PCSS — $0.00 → $500.00Reserved cost-per-event for seerAutofix — $1.00000000 → None Reserved cost-per-event for seerScanner — $0.01000000 → None Reserved budgets — $0.00 for seer budget → NoneThe following changes will take effect on Feb 20, 2024:Pay-as-you-go maximum — $0.00 → $500.00
    at Object.toHaveTextContent (.../components/customers/pendingChanges.spec.tsx:143:23)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

PendingChanges renders pending changes

Stack Traces | 0.071s run time

Error: expect(element).toHaveTextContent()

Expected element to have text content:
  On-demand maximum — $0.00 → $500.00
Received:
  This account has pending changes to the subscriptionThe following changes will take effect on Mar 16, 2022:Plan changes — Developer → Team (Enterprise)Contract period — monthly → annualBilling period — monthly → annualReserved errors — 5,000 → 15,000,000 errorsReserved transactions — 10,000 → 20,000,000 transactionsReserved replays — 50 → 0 replaysReserved attachments — 1 GB → 25 GB attachmentsReserved cron monitors — 1 → 0 monitorSeatsReserved uptime monitors — 1 → 0 uptimeCustom price (ACV) — $0.00 → $50,000.00Custom price for errors — $0.00 → $20,000.00 Custom price for transactions — $0.00 → $29,000.00 Custom price for attachments — $0.00 → $500.00 Custom price for PCSS — $0.00 → $500.00Reserved cost-per-event for seerAutofix — $1.00000000 → None Reserved cost-per-event for seerScanner — $0.01000000 → None Reserved budgets — $0.00 for seer budget → NoneThe following changes will take effect on Feb 16, 2022:Pay-as-you-go maximum — $0.00 → $500.00
    at Object.toHaveTextContent (.../components/customers/pendingChanges.spec.tsx:90:23)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

provisionSubscriptionAction shows manually invoiced on-demand type field when invoiced type is selected

Stack Traces | 0.245s run time

TestingLibraryElementError: Unable to find a label with the text of: On-Demand Max Spend Setting

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at getAllByLabelText (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dist/queries/label-text.js:111:38)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByLabelText (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:284:25)

CustomerOverview renders manually invoiced on-demand details

Stack Traces | 0.252s run time

TestingLibraryElementError: Unable to find an element with the text: Pay-as-you-go Cost-Per-Event Errors:. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByText (.../components/customers/customerOverview.spec.tsx:193:19)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

SubscriptionUpsellBanner should render banner for users on free plan with billing access

Stack Traces | 0.431s run time

TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "Start Trial"

Here are the accessible roles:

  button:

  Name "Learn More":
  ...

  Name "Dismiss":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../views/subscriptionPage/subscriptionUpsellBanner.spec.tsx:54:19)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:549:9)
    at processTimers (node:internal/timers:523:7)

provisionSubscriptionAction shows or hides on-demand CPE fields based on setting

Stack Traces | 0.856s run time

TestingLibraryElementError: Unable to find an accessible element with the role "textbox" and name "On-Demand Max Spend Setting"

Here are the accessible roles:

  dialog:

  Name "":
  ...

  --------------------------------------------------
  document:

  Name "":
  ...

  --------------------------------------------------
  banner:

  Name "":
  ...

  --------------------------------------------------
  textbox:

  Name "Plan":
  ...

  Name "Billing Interval":
  ...

  Name "Billing Type":
  ...

  Name "Pay-as-you-go Max Spend Setting":
  ...

  Name "Soft Cap Type Errors":
  ...

  Name "Soft Cap Type Replays":
  ...

  Name "Soft Cap Type Attachments":
  ...

  Name "Soft Cap Type Cron Monitors":
  ...

  Name "Soft Cap Type Spans":
  ...

  Name "Soft Cap Type Uptime Monitors":
  ...

  Name "Soft Cap Type Logs":
  ...

  Name "Soft Cap Type Continuous Profile Hours":
  ...

  Name "Soft Cap Type UI Profile Hours":
  ...

  Name "Soft Cap Type Issue Fixes":
  ...

  Name "Soft Cap Type Issue Scans":
  ...

  --------------------------------------------------
  checkbox:

  Name "Apply Changes at the End of the Current Billing Period (Oct 24, 2018)":
  ...

  Name "Apply Changes To Current Subscription":
  ...

  Name "Managed Subscription":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  paragraph:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  heading:

  Name "Plan Quotas":
  ...

  Name "Reserved Volume Prices":
  ...

  --------------------------------------------------
  spinbutton:

  Name "Reserved Errors":
  ...

  Name "Reserved Replays":
  ...

  Name "Reserved Attachments (in GB)":
  ...

  Name "Reserved Cron Monitors":
  ...

  Name "Reserved Spans":
  ...

  Name "Reserved Uptime Monitors":
  ...

  Name "Reserved Logs (in GB)":
  ...

  Name "Reserved Continuous Profile Hours":
  ...

  Name "Reserved UI Profile Hours":
  ...

  Name "Reserved Issue Fixes":
  ...

  Name "Reserved Cost-Per-Event Issue Fixes":
  ...

  Name "Reserved Issue Scans":
  ...

  Name "Reserved Cost-Per-Event Issue Scans":
  ...

  Name "Price for Errors":
  ...

  Name "Price for Replays":
  ...

  Name "Price for Attachments":
  ...

  Name "Price for Cron Monitors":
  ...

  Name "Price for Spans":
  ...

  Name "Price for Uptime Monitors":
  ...

  Name "Price for Logs":
  ...

  Name "Price for Continuous Profile Hours":
  ...

  Name "Price for UI Profile Hours":
  ...

  Name "Price for Issue Fixes":
  ...

  Name "Price for Issue Scans":
  ...

  Name "Price for PCSS":
  ...

  Name "Annual Contract Value":
  ...

  --------------------------------------------------
  button:

  Name "Submit":
  ...

  Name "Cancel":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:328:14)

provisionSubscriptionAction does not disable soft cap fields when on-demand is disabled

Stack Traces | 0.89s run time

TestingLibraryElementError: Unable to find an accessible element with the role "textbox" and name "On-Demand Max Spend Setting"

Here are the accessible roles:

  dialog:

  Name "":
  ...

  --------------------------------------------------
  document:

  Name "":
  ...

  --------------------------------------------------
  banner:

  Name "":
  ...

  --------------------------------------------------
  textbox:

  Name "Plan":
  ...

  Name "Billing Interval":
  ...

  Name "Billing Type":
  ...

  Name "Pay-as-you-go Max Spend Setting":
  ...

  Name "Soft Cap Type Errors":
  ...

  Name "Soft Cap Type Replays":
  ...

  Name "Soft Cap Type Attachments":
  ...

  Name "Soft Cap Type Cron Monitors":
  ...

  Name "Soft Cap Type Spans":
  ...

  Name "Soft Cap Type Uptime Monitors":
  ...

  Name "Soft Cap Type Logs":
  ...

  Name "Soft Cap Type Continuous Profile Hours":
  ...

  Name "Soft Cap Type UI Profile Hours":
  ...

  Name "Soft Cap Type Issue Fixes":
  ...

  Name "Soft Cap Type Issue Scans":
  ...

  --------------------------------------------------
  checkbox:

  Name "Apply Changes at the End of the Current Billing Period (Oct 24, 2018)":
  ...

  Name "Apply Changes To Current Subscription":
  ...

  Name "Managed Subscription":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  paragraph:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  heading:

  Name "Plan Quotas":
  ...

  Name "Reserved Volume Prices":
  ...

  --------------------------------------------------
  spinbutton:

  Name "Reserved Errors":
  ...

  Name "Reserved Replays":
  ...

  Name "Reserved Attachments (in GB)":
  ...

  Name "Reserved Cron Monitors":
  ...

  Name "Reserved Spans":
  ...

  Name "Reserved Uptime Monitors":
  ...

  Name "Reserved Logs (in GB)":
  ...

  Name "Reserved Continuous Profile Hours":
  ...

  Name "Reserved UI Profile Hours":
  ...

  Name "Reserved Issue Fixes":
  ...

  Name "Reserved Cost-Per-Event Issue Fixes":
  ...

  Name "Reserved Issue Scans":
  ...

  Name "Reserved Cost-Per-Event Issue Scans":
  ...

  Name "Price for Errors":
  ...

  Name "Price for Replays":
  ...

  Name "Price for Attachments":
  ...

  Name "Price for Cron Monitors":
  ...

  Name "Price for Spans":
  ...

  Name "Price for Uptime Monitors":
  ...

  Name "Price for Logs":
  ...

  Name "Price for Continuous Profile Hours":
  ...

  Name "Price for UI Profile Hours":
  ...

  Name "Price for Issue Fixes":
  ...

  Name "Price for Issue Scans":
  ...

  Name "Price for PCSS":
  ...

  Name "Annual Contract Value":
  ...

  --------------------------------------------------
  button:

  Name "Submit":
  ...

  Name "Cancel":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:392:14)

provisionSubscriptionAction disables soft cap fields when enabling on-demand

Stack Traces | 0.937s run time

TestingLibraryElementError: Unable to find an accessible element with the role "textbox" and name "On-Demand Max Spend Setting"

Here are the accessible roles:

  dialog:

  Name "":
  ...

  --------------------------------------------------
  document:

  Name "":
  ...

  --------------------------------------------------
  banner:

  Name "":
  ...

  --------------------------------------------------
  textbox:

  Name "Plan":
  ...

  Name "Billing Interval":
  ...

  Name "Billing Type":
  ...

  Name "Pay-as-you-go Max Spend Setting":
  ...

  Name "Soft Cap Type Errors":
  ...

  Name "Soft Cap Type Replays":
  ...

  Name "Soft Cap Type Attachments":
  ...

  Name "Soft Cap Type Cron Monitors":
  ...

  Name "Soft Cap Type Spans":
  ...

  Name "Soft Cap Type Uptime Monitors":
  ...

  Name "Soft Cap Type Logs":
  ...

  Name "Soft Cap Type Continuous Profile Hours":
  ...

  Name "Soft Cap Type UI Profile Hours":
  ...

  Name "Soft Cap Type Issue Fixes":
  ...

  Name "Soft Cap Type Issue Scans":
  ...

  --------------------------------------------------
  checkbox:

  Name "Apply Changes at the End of the Current Billing Period (Oct 24, 2018)":
  ...

  Name "Apply Changes To Current Subscription":
  ...

  Name "Managed Subscription":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  paragraph:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  heading:

  Name "Plan Quotas":
  ...

  Name "Reserved Volume Prices":
  ...

  --------------------------------------------------
  spinbutton:

  Name "Reserved Errors":
  ...

  Name "Reserved Replays":
  ...

  Name "Reserved Attachments (in GB)":
  ...

  Name "Reserved Cron Monitors":
  ...

  Name "Reserved Spans":
  ...

  Name "Reserved Uptime Monitors":
  ...

  Name "Reserved Logs (in GB)":
  ...

  Name "Reserved Continuous Profile Hours":
  ...

  Name "Reserved UI Profile Hours":
  ...

  Name "Reserved Issue Fixes":
  ...

  Name "Reserved Cost-Per-Event Issue Fixes":
  ...

  Name "Reserved Issue Scans":
  ...

  Name "Reserved Cost-Per-Event Issue Scans":
  ...

  Name "Price for Errors":
  ...

  Name "Price for Replays":
  ...

  Name "Price for Attachments":
  ...

  Name "Price for Cron Monitors":
  ...

  Name "Price for Spans":
  ...

  Name "Price for Uptime Monitors":
  ...

  Name "Price for Logs":
  ...

  Name "Price for Continuous Profile Hours":
  ...

  Name "Price for UI Profile Hours":
  ...

  Name "Price for Issue Fixes":
  ...

  Name "Price for Issue Scans":
  ...

  Name "Price for PCSS":
  ...

  Name "Annual Contract Value":
  ...

  --------------------------------------------------
  button:

  Name "Submit":
  ...

  Name "Cancel":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:366:14)

provisionSubscriptionAction removes retain on-demand budget toggle when plan changes

Stack Traces | 1.09s run time

Error: Unable to find role="textbox" and name "On-Demand Max Spend Setting"

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.findByRole (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:848:20)

provisionSubscriptionAction calls api with correct seer reserved budget args

Stack Traces | 1.61s run time

Error: Unable to find role="textbox" and name "On-Demand Max Spend Setting"

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.findByRole (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:1383:20)

provisionSubscriptionAction calls api with correct am3 dynamic sampling args

Stack Traces | 1.75s run time

Error: Unable to find role="textbox" and name "On-Demand Max Spend Setting"

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.findByRole (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:1254:20)

provisionSubscriptionAction calls api with seer reserved budget args with 0 values

Stack Traces | 1.79s run time

Error: Unable to find role="textbox" and name "On-Demand Max Spend Setting"

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.findByRole (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:1503:20)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

Mainly just cleaning up where we display the term to users everywhere; some comments and variable names updated but we'll probably need to do the rest (if ever) when we update on the backend too.

sentry · 2025-11-03T16:10:40Z

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

‼️ ReferenceError: tct is not defined in ci:pull_request

ref(billing): Clean up hardcoded on-demand terms

d9aa682

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 30, 2025

vercel bot deployed to Preview October 30, 2025 16:24 View deployment

fix gsApp tests

718f235

vercel bot deployed to Preview October 30, 2025 17:33 View deployment

fix gsAdmin tests

9fa4e36

vercel bot deployed to Preview October 30, 2025 17:47 View deployment

isabellaenriquez marked this pull request as ready for review October 30, 2025 19:14

isabellaenriquez requested review from a team as code owners October 30, 2025 19:14

isabellaenriquez requested a review from a team October 30, 2025 19:14

This comment was marked as outdated.

Sign in to view

fix provisioning form

e4dbbdf

vercel bot deployed to Preview October 30, 2025 20:14 View deployment

vbro approved these changes Oct 30, 2025

View reviewed changes

dashed approved these changes Oct 31, 2025

View reviewed changes

isabellaenriquez merged commit 1615218 into master Oct 31, 2025
47 checks passed

isabellaenriquez deleted the isabella/bil-1672 branch October 31, 2025 13:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ref(billing): Clean up hardcoded on-demand terms #102408

ref(billing): Clean up hardcoded on-demand terms #102408

isabellaenriquez commented Oct 30, 2025 •

edited

Loading

Uh oh!

linear bot commented Oct 30, 2025

Uh oh!

codecov bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

sentry bot commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

ref(billing): Clean up hardcoded on-demand terms #102408

ref(billing): Clean up hardcoded on-demand terms #102408

Conversation

isabellaenriquez commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Oct 30, 2025

Uh oh!

codecov bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 14 Tests Failed:

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

sentry bot commented Nov 3, 2025

Issues attributed to commits in this pull request

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

isabellaenriquez commented Oct 30, 2025 •

edited

Loading

codecov bot commented Oct 30, 2025 •

edited

Loading